fix(runtime): define deferred state as own properties#223
Open
Brooooooklyn wants to merge 1 commit into
Open
Conversation
Brooooooklyn
marked this pull request as ready for review
July 16, 2026 09:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Define the v1 runtime Deferred storage with own data properties before any constructor or disposal writes can reach inherited setters.
This fixes promise creation and settlement when consumers install setters such as
Object.prototype.value, which is exercised by napi-rs iterator-result hardening.Verification
npm install/ full workspace buildWASI_SDK_PATH=... npm run rebuild:w -w packages/testnpm run test:w -w packages/test -- promise/promise.test.jsgit diff --checkTracking context: rolldown/rolldown#9464