-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing #26 #31
base: master
Are you sure you want to change the base?
Fixing #26 #31
Conversation
Server.bind send its info to h.context
The first test that gives an error, the test code or test case have a problem.
At this point, options have hierarchy so, it will check if the role is within hierarchy and it will fail.
I am not sure if the hierarchy test should be made after the role validation or after. The tests were passing because hierarchy was always undefined as hapijs changed the server.bind behavior |
Actually both tests case that fail have the same behavior. |
you should add the roles below in the hierarchy and not fail when the user role is not in the hierarchy definition |
fix unit test
Update acl.js to fix unit test after bind fix
Server.bind send its info to h.context