Enable removal of UNIX lock files #408
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids leaving orphan locks files around after we are done when them. See emscripten-core/emscripten#24035 Fixes: tox-dev#31
I can add a test that confirm the that lock file is deleted. Added a test the races mentioned do not pose a problem is harder. Even if we added some intense stress tests that right conditions for the race might not happen. Hopefully the former is enough? |
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Apr 2, 2025
See tox-dev/filelock#31 and https://stackoverflow.com/a/51070775. Without this change the `cache/symbol_lists` directory ends up full of many lock files that might never get cleaned up (At least since #24029 landed). I'm also sending this change upstream: tox-dev/filelock#408
gaborbernat
approved these changes
Apr 8, 2025
sbc100
commented
Apr 8, 2025
| open_flags = os.O_RDWR | os.O_TRUNC | ||
| if not Path(self.lock_file).exists(): | ||
| open_flags |= os.O_CREAT | ||
| open_flags = os.O_RDWR | os.O_TRUNC | os.O_CREAT |
There was a problem hiding this comment.
I worry a little that I had to remove this workaround which was added in: #317.
I can't seem to find a way to keep both of these fixes in place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids leaving orphan locks files around after we are done when them.
See emscripten-core/emscripten#24035
Fixes: #31