StreamRegistry: support allocating stream without genesis block #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
sergekh2
approved these changes
Jan 30, 2025
bas-vk
force-pushed
the
basvk/genesis_mb_chain
branch
from
c035673 to
45212e8
Compare
bas-vk
requested review from
giuseppecrj,
pfives,
jterzis and
shuhuiluo
as code owners
|
Looks good, will push deploy address for gamma proposal |
shuhuiluo
approved these changes
Feb 3, 2025
bas-vk
force-pushed
the
basvk/genesis_mb_chain
branch
from
8122dd3 to
c697c82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the node passes the protobuf serialised genesis block when allocating a stream to streams registry. As part of migrating to replicated streams the node will stop doing this and nodes can request the genesis block from one of the replicas if it needs it. This saves on calldata and storage costs.
This PR adds 2 functions:
AllocateStreamthat doesn't accept the genesis block bytesgetStreamWithGenesisHashas a future replacement forgetStreamWithGenesisFollow-up changes after this is deployed: