Added two new features to facetoface #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 28, 2013 10:21
…ession starts. (2)Disable New Enrollment xx days before a session starts.
|
I have updated the code, as you commented. Please check and let me know. |
| @@ -561,13 +561,11 @@ function facetoface_update_calendar_entries($session, $facetoface = null){ | |||
| */ | |||
| function facetoface_update_attendees($session) { | |||
| global $USER, $DB; | |||
|
|
|||
|
Few more comments, once those are fixed I'll test it out :-) |
…Database calls that is made in the renderer
|
I have pushed a new update as according to your input. (Except for the calling of DB in renderer). |
| $table = new xmldb_table('facetoface'); | ||
| $field = new xmldb_field('disablewithindays', XMLDB_TYPE_INTEGER, '3', null, XMLDB_NOTNULL, null, '0', 'approvalreqd'); | ||
|
|
||
|
|
| @@ -34,7 +34,8 @@ | |||
| <FIELD NAME="shortname" TYPE="char" LENGTH="32" NOTNULL="false" SEQUENCE="false" PREVIOUS="timemodified" NEXT="showoncalendar"/> | |||
| <FIELD NAME="showoncalendar" TYPE="int" LENGTH="1" NOTNULL="true" UNSIGNED="true" DEFAULT="1" SEQUENCE="false" PREVIOUS="shortname" NEXT="approvalreqd"/> | |||
| <FIELD NAME="approvalreqd" TYPE="int" LENGTH="1" NOTNULL="true" UNSIGNED="true" DEFAULT="0" SEQUENCE="false" PREVIOUS="showoncalendar" NEXT="usercalentry"/> | |||
| <FIELD NAME="usercalentry" TYPE="int" LENGTH="1" NOTNULL="true" UNSIGNED="true" DEFAULT="1" SEQUENCE="false" PREVIOUS="approvalreqd"/> | |||
| <FIELD NAME="usercalentry" TYPE="int" LENGTH="1" NOTNULL="true" UNSIGNED="true" DEFAULT="1" SEQUENCE="false" PREVIOUS="approvalreqd" NEXT="disablewithindays"/> | |||
| <FIELD NAME="disablewithindays" TYPE="int" LENGTH="3" NOTNULL="true" UNSIGNED="true" DEFAULT="0" SEQUENCE="false" PREVIOUS="usercalentry"/> | |||
|
Hopefully my comments about the Database calls is helpful. If you have any questions let me know. Thanks, |
added 3 commits
June 5, 2013 11:12
…pace, extra lines, and indentation. The css 100% width on styles.php is not working, and I am still working on the database calls mentioned in the last comment
…session_dates function
|
I have updated the code as instructed. And I have removed a couple of database calls from renderer.php and lib.php. Please refer to todays commit. |
|
The issue with 100% width on styles.css has been fixed as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have added two new features:
Thank you.