Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New completion condition: Session is over #2

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

New completion condition: Session is over #2

wants to merge 7 commits into from

Conversation

emeneo
Copy link

@emeneo emeneo commented Jun 1, 2012

Hello

This condition is a thick box available if the Activity completion selected is : Show ...

The completion condition are: A session of the module facetoface must be over with people still attendee to this session and the module must have the condition enable in the setting.

The verification of thoses condition and the completion happen when the cron.php of facetoface is launch, because my idea was to do with the 'schedule task' of windows a daily update of the database by running the admin/cron.php everyday.

My modification are in the lib.php and the mod_form.php. I had to add a field completionsession in facetoface table, so that why I modify the db/upgrade.php. Finally I modify the view.php of facetoface just to quickly enable the condition require view for facetoface.

Let me know what do you think and if it is working for you or not.
Thanks

@aly
Copy link
Contributor

aly commented Jun 7, 2012

Hi David,

Moodle currently supports multiple database types. I have noticed you have used mysql specific database functions. These need to be updated before this can be merged into core Face-to-face. Once this has been done I can do some testing and let you know if I find any other problems.

Cheers,
Alastair

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants