Moodle 2.2 Fixes #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made it so sidebars appear in all facetoface screens. Fixed Add/Remove Attendees. Fixed export functionality.
ghost
assigned 
|
Hi, Sorry it has taken me so long to get to this. Your patch looks good and has fixed some things I've missed unfortunately it is no longer based off the latest patchset and needs to be rebased. If you could do this I will merge it in. Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there. We use Face to Face here at Queen's University, and one of the tasks that we need to get done prior to migrating from 1.9.X to 2.2.X is to make Face to Face compatible. To that end I've been doing some work on it.
Fixed "Help Icon" popup and hover text formatting. The en lang file had valid html in them, but it was producing some weird looking/invalid pages. Haven't checked other lang files.
Made it so sidebars appear in all facetoface pages. Changed require_course_login calls to specify $cm where possible, added $PAGE->set_layout where not.
Fixed Add/Remove Attendees. Searching wasn't functioning at all. Reworked to use $DB->sql_like built in functions, with records instead of recordsets.
Fixed export functionality. Was broken in developer mode due to warnings/errors being printed, and there were issues with duplicate IDs in the data it was exporting.