Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce function #925

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Reduce function #925

wants to merge 28 commits into from

Conversation

dasom-jo
Copy link
Contributor

@dasom-jo dasom-jo commented Jan 2, 2025

No description provided.

@dasom-jo dasom-jo requested a review from raon0211 as a code owner January 2, 2025 10:16
Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 3:29am

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.49%. Comparing base (e4fb039) to head (12a2313).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #925   +/-   ##
=======================================
  Coverage   99.49%   99.49%           
=======================================
  Files         367      368    +1     
  Lines        3174     3187   +13     
  Branches      950      953    +3     
=======================================
+ Hits         3158     3171   +13     
  Misses         15       15           
  Partials        1        1           

@raon0211
Copy link
Collaborator

Hey, sorry for the late reply, and thanks for your pull request!

We actually have a function called pullAt in es-toolkit that’s pretty similar. I think the name pullAt fits the behavior a bit better than reduce—since reduce could easily be confused with Array.prototype.reduce.

Could you take a look at our pullAt function and let me know what you think?

@dasom-jo
Copy link
Contributor Author

dasom-jo commented Jan 30, 2025

Sorry, there was a mistake. I am correcting it now.

@raon0211
Copy link
Collaborator

Let us look at the lint issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants