Open
Conversation
guru-web3
reviewed
Jun 1, 2022
| @@ -1,39 +1,13987 @@ | |||
| { | |||
| "name": "vue-app", | |||
| "version": "0.1.0", | |||
| "lockfileVersion": 1, | |||
| "lockfileVersion": 2, | |||
Contributor
There was a problem hiding this comment.
should we commit package lock files for test commits? cc: @metallicalfa2
guru-web3
reviewed
Jun 1, 2022
guru-web3
reviewed
Jun 1, 2022
Comment on lines
+52
to
+62
| const [page1] = await Promise.all([ | ||
| page.waitForEvent("popup"), | ||
| page.click("button >> text=Sign All Transactions") | ||
| ]); | ||
|
|
||
| await page1.waitForSelector("text=Confirm Permission"); | ||
| await page1.click("button >> text=Approve") | ||
| await wait(1500); | ||
|
|
||
| const consoleData = JSON.parse(await page.locator("#console > p").innerText()); | ||
| expect(consoleData).toHaveLength(3); |
Contributor
There was a problem hiding this comment.
can we use try, catch to test error sceneraio's console to have better coverage?
Author
There was a problem hiding this comment.
can you clarify how try catch will increase test coverage here?
# Conflicts: # examples/vue-app/package-lock.json # examples/vue-app/package.json # examples/vue-app/src/components/HelloWorld.vue # package-lock.json
guru-web3
approved these changes
Jun 8, 2022
Contributor
guru-web3
left a comment
guru-web3
left a comment
There was a problem hiding this comment.
looks good cc @metallicalfa2
please confirm if this is okay to show in example app
<button @click="() => transfer(10001)">Transfer error
<button @click="() => lookupDepositSPL(mintAddress, 100)" :disabled="network!==testnet">Custom program error (Testnet)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add e2e testing for example app