Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: in_menu filter #402

Merged
merged 4 commits into from
Sep 20, 2024
Merged

feat: in_menu filter #402

merged 4 commits into from
Sep 20, 2024

Conversation

dopry
Copy link
Collaborator

@dopry dopry commented Sep 1, 2024

No description provided.

zerolab
zerolab requested changes Sep 17, 2024
View reviewed changes
Copy link
Member

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there

grapple/types/structures.py Outdated Show resolved Hide resolved
grapple/utils.py Outdated Show resolved Hide resolved
@dopry dopry force-pushed the feat/pages-in_menu-argument branch 4 times, most recently from 096ff99 to c518e7a Compare September 17, 2024 20:42
zerolab
zerolab requested changes Sep 20, 2024
View reviewed changes
Copy link
Member

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicks left, then we're good to go

grapple/types/structures.py Outdated Show resolved Hide resolved
grapple/types/structures.py Outdated Show resolved Hide resolved
@dopry
Copy link
Collaborator Author

dopry commented Sep 20, 2024

nitpicks left, then we're good to go

Committed, btw, feel free to commit that kind of stuff to my branches.

@zerolab
Copy link
Member

zerolab commented Sep 20, 2024

Cheers @dopry
To be honest, I forgot I can do that 🤦🏼

@dopry
Copy link
Collaborator Author

dopry commented Sep 20, 2024

Sometimes you can't, depends on the repo settings

@zerolab zerolab merged commit 48b983d into torchbox:main Sep 20, 2024
14 checks passed
@dopry dopry deleted the feat/pages-in_menu-argument branch September 20, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerolab zerolab zerolab requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dopry @zerolab