Fix issue with querying value on EmbedBlock #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakubMastalerz
force-pushed
the
fix/embed-block-value
branch
from
22356e5
to
e2479b6
Compare
JakubMastalerz
changed the title
zerolab
reviewed
Jul 29, 2024
zerolab
reviewed
Aug 14, 2024
zerolab
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #395
This PR changes the incorrectly named
resolve_raw_valuefunction toresolve_valueonEmbedBlock. This fixes an issue where it was impossible to query forvalueon embeds using wagtail_grapple.