Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure ruff version consistency #393

Merged
merged 2 commits into from
May 10, 2024
Merged

Ensure ruff version consistency #393

merged 2 commits into from
May 10, 2024

Conversation

zerolab
Copy link
Member

@zerolab zerolab commented May 10, 2024

Fixes #392

@zerolab zerolab mentioned this pull request May 10, 2024
Closed
@jams2
Copy link
Contributor

jams2 commented May 10, 2024

Question: why not add a ruff requirement in pyproject.toml?

@zerolab
Copy link
Member Author

zerolab commented May 10, 2024 •
edited
Loading

Because:

  • we lint in CI with pre-commit.ci
  • locally we encourage pre-commit
  • the ruff.yml GitHub Action is for convenience and I don't want to install extra deps (footprint and all that)

@zerolab zerolab merged commit 166e78a into main May 10, 2024
16 checks passed
@zerolab zerolab deleted the chore/ruff branch May 10, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent Ruff versions between CI pipeline and test app requirements.
2 participants
@zerolab @jams2