feat: use pathlib.Path for template paths #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the django-pattern-library to use pathlib.Path for template paths. This ensures that the paths are handled consistently across different operating systems, including Windows. The following functions have been modified to use pathlib.Path: path_to_section() section_for() get_template_dirs() get_pattern_config_str() get_pattern_markdown() Additionally, the TemplateRenderer.get_pattern_templates() method has been updated to use pathlib.Path for template paths. possibly related issue: torchbox#116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
note (haven't tested yet will do asap)
This commit modifies
utils.pyto usepathlib.Pathfor template paths. This ensures that the paths are handled consistently across different operating systems, including Windows. The following functions have been modified to use pathlib.Path: path_to_section()section_for()
get_template_dirs()
get_pattern_config_str()
get_pattern_markdown()
Additionally, the TemplateRenderer.get_pattern_templates() method has been updated to use pathlib.Path for template paths.
Fixes #116
possibly related issue: #116
Checklist