Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jinja templates #206

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Jinja templates #206

wants to merge 10 commits into from

Conversation

gone
Copy link

@gone gone commented Oct 27, 2022

Description

This is a first pass at jinja support.

Right now this supports the major features I can account for, outside of overriding extends and includes tags.

I haven't really checked against the styleguide/updated documentation/tests so I think this is just in wip status

Fixes # (issue) #171

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added an appropriate CHANGELOG entry

@gone gone marked this pull request as ready for review July 31, 2023 20:24
@gone
Copy link
Author

gone commented Jul 31, 2023

We got overriting the extends and includes tags working, so I think this is ready for review!

@gone gone changed the title First pass at Jinja support Jinja templates Aug 2, 2023
@thibaudcolas
Copy link
Member

Omg! Thank you @gone, I’ll find some time to review this properly.

@gone
Copy link
Author

gone commented Aug 4, 2023

Cool yeah, happy to make any changes!

@maribedran
Copy link

@gone I opened a PR to your branch fixing some issues, but I could also open a new one directly here if it's easier for @thibaudcolas to review the entire thing at once. Let me know what you folks prefer.

@cclauss
Copy link
Contributor

cclauss commented Jan 16, 2024

@gone Given that #171 is closed, please rebase this PR.

@CuriousLearner
Copy link

Hey @gone 👋🏼

I've opened up a PR to your repo here: gone#6

@thibaudcolas If it's easier, I can open it up directly on the Torchbox upstream. Please let me know what you folks would prefer.

Many thanks! 🙌🏼

@CuriousLearner CuriousLearner mentioned this pull request Jun 21, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants