support probe pod's toleration - #193
Merged
Merged
Conversation
Signed-off-by: Shinya Hayashi <shinya-hayashi@cybozu.co.jp>
There was a problem hiding this comment.
Pull request overview
This PR adds support for configuring Kubernetes pod tolerations for PieProbe “probe” CronJob pods, allowing them to schedule onto tainted nodes when required.
Changes:
- Adds
spec.tolerationsto the PieProbe API type and regenerates deepcopy code. - Applies
pieProbe.Spec.Tolerationsonto the CronJob pod template spec in the controller. - Extends controller tests to verify tolerations propagate to all generated probe CronJobs.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/controller/pie/pieprobe_controller.go | Propagates PieProbe.spec.tolerations into the CronJob pod template. |
| internal/controller/pie/pieprobe_controller_test.go | Adds an envtest verifying tolerations are set on all probe CronJobs after updating the CR. |
| config/crd/bases/pie.topolvm.io_pieprobes.yaml | Updates the generated CRD schema to include spec.tolerations. |
| charts/pie/templates/pie.topolvm.io_pieprobes.yaml | Mirrors the CRD schema change in the Helm chart CRD template. |
| api/pie/v1alpha1/zz_generated.deepcopy.go | Regenerates deepcopy logic to include the new Tolerations slice. |
| api/pie/v1alpha1/pieprobe_types.go | Adds Tolerations []corev1.Toleration to the PieProbe spec. |
Files not reviewed (1)
- api/pie/v1alpha1/zz_generated.deepcopy.go: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ushitora-anqou
approved these changes
Aug 31, 2026
molpako
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shinya Hayashi shinya-hayashi@cybozu.co.jp