Skip to content

fix(PM-1494): Fix date format #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ workflows:
context : org-global
filters:
branches:
only: ['develop', 'migration-setup', 'pm-1494']
only: ['develop', 'migration-setup', 'pm-1494_1']

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch name pm-1494_1 seems to be a temporary or specific branch name. Ensure that this change is intentional and aligns with your branching strategy. If the branch name is meant to be pm-1494, consider reverting this change.

- deployProd:
context : org-global
filters:
Expand Down
2 changes: 1 addition & 1 deletion src/routes/copilotRequest/approveRequest.service.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ module.exports = (req, data, existingTransaction) => {
work_manager_url: config.get('workManagerUrl'),
opportunity_type: getCopilotTypeLabel(type),
opportunity_title: opportunityTitle,
start_date: moment.utc(startDate).format("YYYY-MM-DD HH:mm:ss [UTC]"),
start_date: moment(startDate).format("DD-MM-YYYY"),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in date format from YYYY-MM-DD HH:mm:ss [UTC] to DD-MM-YYYY may affect how the date is interpreted in different parts of the application. Ensure that the new format is compatible with all systems that consume this date. Additionally, consider whether the time component is necessary for the application's functionality, as it has been removed in this change.

},
sendgrid_template_id: TEMPLATE_IDS.CREATE_REQUEST,
recipients: [recipient],
Expand Down