fix(PM-1494): Add extra info for copilot email #830

hentrymartin · 2025-07-21T21:49:50Z

What's in this PR?

Added extra info like opportunity title, start date and type to email sent to copilots when a request is created

Ticket link - https://topcoder.atlassian.net/browse/PM-1494

github-actions · 2025-07-21T21:50:04Z

src/routes/copilotRequest/approveRequest.service.js

+                  ],
+                });
+                req.log.debug(opportunityWithProjectInfo, "debug log opportunityWithProjectInfo");
+                const data = opportunityWithProjectInfo.copilotRequest.data;


Consider using a more descriptive variable name instead of reusing data to avoid confusion with the data parameter passed to the function.

github-actions · 2025-07-21T21:50:06Z

src/routes/copilotRequest/approveRequest.service.js

@@ -71,6 +96,9 @@ module.exports = (req, data, existingTransaction) => {
                      user_name: subject.handle,
                      opportunity_details_url: `${copilotPortalUrl}/opportunity/${opportunity.id}`,
                      work_manager_url: config.get('workManagerUrl'),
+                      opportunity_type: getCopilotTypeLabel(opportunity.type),
+                      opportunity_title: opportunityWithProjectInfo.project.name,


Consider checking if opportunityWithProjectInfo.project is defined before accessing name to prevent potential runtime errors if project is undefined.

github-actions · 2025-07-21T21:50:06Z

src/routes/copilotRequest/approveRequest.service.js

@@ -71,6 +96,9 @@ module.exports = (req, data, existingTransaction) => {
                      user_name: subject.handle,
                      opportunity_details_url: `${copilotPortalUrl}/opportunity/${opportunity.id}`,
                      work_manager_url: config.get('workManagerUrl'),
+                      opportunity_type: getCopilotTypeLabel(opportunity.type),
+                      opportunity_title: opportunityWithProjectInfo.project.name,
+                      start_date: moment.utc(data.startDate).format(),


Ensure that data.startDate is a valid date before formatting it with moment.utc() to avoid unexpected results or errors.

github-actions · 2025-07-22T15:25:13Z

src/routes/copilotRequest/approveRequest.service.js

+                    },
+                  ],
+                });
+                req.log.debug(opportunityWithProjectInfo);


The debug log statement on line 85 has been split into two separate log statements. Consider combining them into a single log statement to maintain clarity and avoid redundancy.

github-actions · 2025-07-22T15:25:13Z

src/routes/copilotRequest/approveRequest.service.js

+                  ],
+                });
+                req.log.debug(opportunityWithProjectInfo);
+                req.log.debug("debug log opportunityWithProjectInfo")


The log message on line 86 ('debug log opportunityWithProjectInfo') is not associated with any specific data. Consider providing more context or data with this log message to make it more informative.

github-actions · 2025-07-22T15:53:23Z

src/routes/copilotRequest/approveRequest.service.js

+                    },
+                  ],
+                });
+                req.log.info(opportunity);


Consider removing the req.log.info(opportunity); line if it is not necessary to log the opportunity object separately from opportunityWithProjectInfo. Logging both might lead to redundant information in the logs.

github-actions · 2025-07-22T18:06:05Z

src/routes/copilotRequest/approveRequest.service.js

@@ -60,6 +61,27 @@ module.exports = (req, data, existingTransaction) => {
                  .create(data, { transaction });
              }))
              .then(async (opportunity) => {
+                const copilotRequestWithProjectInfo = await models.CopilotRequest.findOne({


The variable name copilotRequestWithProjectInfo suggests that it contains both copilot request and project information. Ensure that the variable accurately reflects the data it holds, especially since the include statement only specifies the Project model.

github-actions · 2025-07-22T18:06:05Z

src/routes/copilotRequest/approveRequest.service.js

@@ -60,6 +61,27 @@ module.exports = (req, data, existingTransaction) => {
                  .create(data, { transaction });
              }))
              .then(async (opportunity) => {
+                const copilotRequestWithProjectInfo = await models.CopilotRequest.findOne({
+                  where: { id: opportunity.copilotRequestId },


The where clause uses opportunity.copilotRequestId. Verify that opportunity has a property copilotRequestId and that it is correctly set before this point in the code.

github-actions · 2025-07-22T18:06:08Z

src/routes/copilotRequest/approveRequest.service.js

+                    },
+                  ],
+                });
+                req.log.info(copilotRequestWithProjectInfo);


The variable copilotRequestWithProjectInfo is used here, but it is not defined in the provided diff. Ensure that this variable is correctly defined and initialized before this line.

github-actions · 2025-07-22T18:06:09Z

src/routes/copilotRequest/approveRequest.service.js

+                });
+                req.log.info(copilotRequestWithProjectInfo);
+                req.log.debug("debug log copilotRequestWithProjectInfo")
+                const data = copilotRequestWithProjectInfo.data;


The variable copilotRequestWithProjectInfo is used to access .data, but it is not clear from the diff if this variable is correctly structured to have a .data property. Verify that copilotRequestWithProjectInfo has the expected structure.

github-actions · 2025-07-22T18:06:12Z

src/routes/copilotRequest/approveRequest.service.js

@@ -71,6 +93,9 @@ module.exports = (req, data, existingTransaction) => {
                      user_name: subject.handle,
                      opportunity_details_url: `${copilotPortalUrl}/opportunity/${opportunity.id}`,
                      work_manager_url: config.get('workManagerUrl'),
+                      opportunity_type: getCopilotTypeLabel(opportunity.type),
+                      opportunity_title: copilotRequestWithProjectInfo.project.name,


The variable copilotRequestWithProjectInfo should be checked to ensure it is defined and has the expected structure before accessing project.name. This will prevent potential runtime errors if the structure of copilotRequestWithProjectInfo is not as expected.

github-actions · 2025-07-22T18:29:54Z

src/routes/copilotRequest/approveRequest.service.js

@@ -71,6 +79,9 @@ module.exports = (req, data, existingTransaction) => {
                      user_name: subject.handle,
                      opportunity_details_url: `${copilotPortalUrl}/opportunity/${opportunity.id}`,
                      work_manager_url: config.get('workManagerUrl'),
+                      opportunity_type: getCopilotTypeLabel(opportunity.type),
+                      opportunity_title: data.opportunityTitle,


The variable data.opportunityTitle is being used here. Ensure that data.opportunityTitle is always defined and has the correct value before this line is executed. Consider adding validation earlier in the code to prevent potential runtime errors.

github-actions · 2025-07-22T19:33:05Z

src/routes/copilotRequest/approveRequest.service.js

+                  where: { id: opportunity.copilotRequestId },
+                });
+                req.log.info(copilotRequestWithProjectInfo);
+                req.log.info(opportunity.copilotRequestId);


It seems like you're logging opportunity.copilotRequestId here. Ensure that this log is necessary for debugging or monitoring purposes, as excessive logging can clutter log files and make it harder to find important information.

github-actions · 2025-07-22T19:33:05Z

src/routes/copilotRequest/approveRequest.service.js

+                req.log.info(copilotRequestWithProjectInfo);
+                req.log.info(opportunity.copilotRequestId);
+                req.log.debug("debug log copilotRequestWithProjectInfo")
+                const data = copilotRequestWithProjectInfo.data;


The variable data is being redeclared here, which can lead to confusion or errors. Consider using a different variable name to avoid shadowing the data parameter of the function.

github-actions · 2025-07-22T20:01:03Z

src/routes/copilotRequest/approveRequest.service.js

@@ -16,7 +17,7 @@ const resolveTransaction = (transaction, callback) => {
 };

 module.exports = (req, data, existingTransaction) => {
-  const { projectId, copilotRequestId } = data;
+  const { projectId, copilotRequestId, opportunityTitle, type } = data;


The destructuring assignment now includes opportunityTitle and type, but it's unclear how these new variables are used in the function. Ensure that they are necessary for the logic and are utilized appropriately within the function body.

github-actions · 2025-07-22T20:01:07Z

src/routes/copilotRequest/approveRequest.service.js

@@ -71,6 +72,9 @@ module.exports = (req, data, existingTransaction) => {
                      user_name: subject.handle,
                      opportunity_details_url: `${copilotPortalUrl}/opportunity/${opportunity.id}`,
                      work_manager_url: config.get('workManagerUrl'),
+                      opportunity_type: getCopilotTypeLabel(type),


The variable type is used here, but it is not clear from the diff if type is defined or correctly assigned a value. Ensure that type is defined and holds the expected value before using it in getCopilotTypeLabel(type).

github-actions · 2025-07-22T20:01:07Z

src/routes/copilotRequest/approveRequest.service.js

@@ -71,6 +72,9 @@ module.exports = (req, data, existingTransaction) => {
                      user_name: subject.handle,
                      opportunity_details_url: `${copilotPortalUrl}/opportunity/${opportunity.id}`,
                      work_manager_url: config.get('workManagerUrl'),
+                      opportunity_type: getCopilotTypeLabel(type),
+                      opportunity_title: opportunityTitle,


The variable opportunityTitle is used here, but it is not clear from the diff if opportunityTitle is defined or correctly assigned a value. Ensure that opportunityTitle is defined and holds the expected value before using it.

github-actions · 2025-07-22T20:01:09Z

src/routes/copilotRequest/create.js

@@ -98,6 +98,7 @@ module.exports = [
              createdBy: req.authUser.userId,
              updatedBy: req.authUser.userId,
              type: copilotRequest.data.projectType,
+              opportunityTitle: copilotRequest.data.opportunityTitle,


Ensure that copilotRequest.data.opportunityTitle is always defined and valid before using it here. Consider adding validation or a default value to prevent potential errors if opportunityTitle is missing or undefined.

github-actions · 2025-07-22T20:19:18Z

src/routes/copilotRequest/approveRequest.service.js

@@ -71,6 +72,9 @@ module.exports = (req, data, existingTransaction) => {
                      user_name: subject.handle,
                      opportunity_details_url: `${copilotPortalUrl}/opportunity/${opportunity.id}`,
                      work_manager_url: config.get('workManagerUrl'),
+                      opportunity_type: getCopilotTypeLabel(type),
+                      opportunity_title: opportunityTitle,
+                      start_date: moment.utc(startDate).format(),


The variable startDate is used here, but it seems like data.startDate was used previously. Ensure that startDate is defined and accessible in this context, or if data.startDate was intended, consider reverting to the original.

github-actions · 2025-07-22T20:19:21Z

src/routes/copilotRequest/create.js

@@ -98,6 +98,8 @@ module.exports = [
              createdBy: req.authUser.userId,
              updatedBy: req.authUser.userId,
              type: copilotRequest.data.projectType,
+              opportunityTitle: copilotRequest.data.opportunityTitle,
+              startDate: copilotRequest.data.startDate,


Ensure that copilotRequest.data.startDate is properly validated and sanitized before being used here to prevent potential security issues or data inconsistencies.

github-actions · 2025-07-22T21:32:21Z

src/routes/copilotRequest/approveRequest.service.js

@@ -1,11 +1,13 @@
 import _ from 'lodash';
 import config from 'config';
+import moment from 'moment';
+import { Op } from 'sequelize';


The import statement for Op from 'sequelize' has been moved but not modified. Consider reverting the change if it was unintentional, as it does not affect functionality.

src/routes/copilotRequest/approveRequest.service.js

github-actions · 2025-07-22T22:34:19Z

src/routes/copilotRequest/approveRequest.service.js

@@ -71,6 +73,9 @@ module.exports = (req, data, existingTransaction) => {
                      user_name: subject.handle,
                      opportunity_details_url: `${copilotPortalUrl}/opportunity/${opportunity.id}`,
                      work_manager_url: config.get('workManagerUrl'),
+                      opportunity_type: getCopilotTypeLabel(type),
+                      opportunity_title: opportunityTitle,
+                      start_date: moment.utc(startDate).format("YYYY-MM-DD HH:mm:ss [UTC]"),


The date format has been changed from DD-MM-YYYY h:mm:ss a to YYYY-MM-DD HH:mm:ss [UTC]. Ensure that this new format is compatible with all systems and services that consume this data, as it may affect parsing or display logic.

hentrymartin added 2 commits July 21, 2025 23:48

fix: add extra info copilots email

473b060

fix: add extra info copilots email

b63b2ad

hentrymartin changed the title ~~fix(PM-1494): Add extra info for copilot email~~ [Work in progress] fix(PM-1494): Add extra info for copilot email Jul 21, 2025

github-actions bot reviewed Jul 21, 2025

View reviewed changes

hentrymartin added the wip label Jul 21, 2025

fix: add extra info copilots email

1a8d9f2

github-actions bot reviewed Jul 22, 2025

View reviewed changes

fix: add extra info copilots email

e6f3595

github-actions bot reviewed Jul 22, 2025

View reviewed changes

fix: add extra info copilots email

f63c580

github-actions bot reviewed Jul 22, 2025

View reviewed changes

fix: add extra info copilots email

2f46d05

github-actions bot reviewed Jul 22, 2025

View reviewed changes

fix: add extra info copilots email

2201ec4

github-actions bot reviewed Jul 22, 2025

View reviewed changes

hentrymartin added 2 commits July 22, 2025 21:58

updated from develop

36c6e7b

updated from develop

cf50f64

github-actions bot reviewed Jul 22, 2025

View reviewed changes

updated from develop

56eb2b6

github-actions bot reviewed Jul 22, 2025

View reviewed changes

hentrymartin added 2 commits July 22, 2025 23:28

fix: type

fed04b8

fix: type

64091d5

github-actions bot reviewed Jul 22, 2025

View reviewed changes

fix: date format

eaf2116

github-actions bot reviewed Jul 22, 2025

View reviewed changes

src/routes/copilotRequest/approveRequest.service.js Outdated Show resolved Hide resolved

fix: date format

5bf08be

github-actions bot reviewed Jul 22, 2025

View reviewed changes

hentrymartin requested a review from kkartunov July 22, 2025 22:34

hentrymartin changed the title ~~[Work in progress] fix(PM-1494): Add extra info for copilot email~~ fix(PM-1494): Add extra info for copilot email Jul 22, 2025

kkartunov approved these changes Jul 23, 2025

View reviewed changes

kkartunov merged commit a2a668b into develop Jul 23, 2025
2 checks passed

hentrymartin deleted the pm-1494 branch July 23, 2025 05:41

fix(PM-1494): Add extra info for copilot email #830

fix(PM-1494): Add extra info for copilot email #830

Uh oh!

Conversation

hentrymartin commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What's in this PR?

Uh oh!

github-actions bot Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hentrymartin commented Jul 21, 2025 •

edited

Loading