Skip to content

Conversation

@kkartunov
Copy link
Collaborator

Related JIRA Ticket:

https://topcoder.atlassian.net/browse/PM-2677

What's in this PR?

@kkartunov kkartunov requested a review from jmgasper as a code owner November 2, 2025 09:50

if (filters.winnerIds && filters.winnerIds.length > 0) {
payload.winnerIds = filters.winnerIds
payload.winnerIds = filters.winnerIds.map(id => id.toString())
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ correctness]
Converting winnerIds to strings using map(id => id.toString()) assumes that all elements in filters.winnerIds are valid and convertible to strings. Ensure that filters.winnerIds contains only valid data types to prevent runtime errors.

@jmgasper jmgasper merged commit c958bd7 into master Nov 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants