PM-1526 Fix copilot requests sorting on title #1159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // Handle undefined/null values safely | ||
| if (aField === undefined && bField === undefined) return 0 | ||
| if (aField === undefined) return 1 | ||
| if (bField === undefined) return -1 | ||
| return sort.direction === 'asc' | ||
| ? aField.localeCompare(bField) |
There was a problem hiding this comment.
Consider adding a check for null values in addition to undefined when comparing aField and bField. This ensures that both null and undefined are handled consistently, as the current implementation only checks for undefined. You might want to use aField == null and bField == null to cover both cases.
kkartunov
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-1526
What's in this PR?
Fixes sort on title due to missing titles in some records