PM-1499 edit copilot request #1148

vas3a · 2025-07-22T10:53:38Z

Related JIRA Ticket:

https://topcoder.atlassian.net/browse/PM-1499

What's in this PR?

src/apps/copilots/src/copilots.routes.tsx

src/apps/copilots/src/pages/copilot-opportunity-list/index.tsx

src/apps/copilots/src/pages/copilot-request-form/index.tsx

github-actions · 2025-07-22T10:54:04Z

src/apps/copilots/src/pages/copilot-request-form/index.tsx

+    const { data: copilotRequestData }: CopilotRequestResponse = useCopilotRequest(routeParams.requestId)
+
+    useEffect(() => {
+        if (copilotRequestData) {


Ensure that copilotRequestData has the expected structure before setting it to formValues to prevent potential runtime errors.

github-actions · 2025-07-22T10:54:04Z

src/apps/copilots/src/pages/copilot-request-form/index.tsx

+    }, [copilotRequestData])
+
+    const { data: projects = [] }: ProjectsResponse = useProjects(undefined, {
+        filter: { id: copilotRequestData?.projectId },


The filter object is using optional chaining with copilotRequestData?.projectId. Ensure that the logic correctly handles cases where projectId is undefined.

github-actions · 2025-07-22T10:54:04Z

src/apps/copilots/src/pages/copilot-request-form/index.tsx

+
+    const { data: projects = [] }: ProjectsResponse = useProjects(undefined, {
+        filter: { id: copilotRequestData?.projectId },
+        isPaused: () => !copilotRequestData?.projectId,


The isPaused function uses optional chaining with copilotRequestData?.projectId. Ensure that the logic correctly handles cases where projectId is undefined.

github-actions · 2025-07-22T10:54:07Z

src/apps/copilots/src/pages/copilot-request-form/index.tsx

@@ -198,9 +235,10 @@ const CopilotRequestForm: FC<{}> = () => {
        if (isEmpty(updatedFormErrors)) {
            const cleanedFormValues: any = Object.fromEntries(
                Object.entries(formValues)
-                    .filter(([, value]) => value !== ''), // Excludes null and undefined
+                    // Excludes null and undefined
+                    .filter(([field, value]) => editableFields.includes(field) && value !== ''),


Consider checking if editableFields is defined and is an array before using includes to avoid potential runtime errors.

github-actions · 2025-07-22T10:54:07Z

src/apps/copilots/src/pages/copilot-request-form/index.tsx

            )
-            saveCopilotRequest(cleanedFormValues)
+            saveCopilotRequest({ ...cleanedFormValues, id: copilotRequestData?.id })


Ensure that copilotRequestData?.id is defined and valid before spreading it into cleanedFormValues to prevent unintended behavior.

github-actions · 2025-07-22T10:54:09Z

src/apps/copilots/src/pages/copilot-request-form/index.tsx

+                        {' '}
+                        {
+                            copilotRequestData?.id
+                                ? 'Use this form to update the copilot request for your project.'


Consider simplifying the conditional rendering logic for the message. The current ternary operator with nested strings can be hard to read. You might want to extract the message into a separate variable for clarity.

github-actions · 2025-07-22T10:54:12Z

src/apps/copilots/src/pages/copilot-request-form/index.tsx

+                        label='Title'
+                        name='opportunityTitle'
+                        placeholder='Enter a title for the opportunity'
+                        value={formValues.opportunityTitle?.toString()}


Ensure that formValues.opportunityTitle is properly initialized to avoid potential undefined errors when calling toString().

github-actions · 2025-07-22T10:54:12Z

src/apps/copilots/src/pages/copilot-request-form/index.tsx

+                        name='opportunityTitle'
+                        placeholder='Enter a title for the opportunity'
+                        value={formValues.opportunityTitle?.toString()}
+                        onChange={bind(handleFormValueChange, this, 'opportunityTitle')}


Consider using a more descriptive function name instead of handleFormValueChange to clearly indicate its purpose or the specific form field it handles.

github-actions · 2025-07-22T10:54:14Z

src/apps/copilots/src/pages/copilot-request-form/index.tsx

@@ -275,6 +335,7 @@ const CopilotRequestForm: FC<{}> = () => {
                        dirty
                        isClearable
                        error={formErrors.projectId}
+                        options={projectOptions}


Ensure that projectOptions is properly defined and populated with the expected data structure before being passed to the Select component. This will prevent potential runtime errors if projectOptions is undefined or incorrectly formatted.

github-actions · 2025-07-22T10:54:17Z

...ps/copilots/src/pages/copilot-requests/copilot-request-modal/CopilotRequestModal.module.scss

@@ -13,3 +13,7 @@
        background: $black-10;
    }
 }
+
+.mrAuto {


Consider renaming the class .mrAuto to a more descriptive name that reflects its purpose or the element it is applied to, for better readability and maintainability.

github-actions · 2025-07-22T10:54:20Z

src/apps/copilots/src/pages/copilot-requests/copilot-request-modal/CopilotRequestModal.tsx

@@ -1,4 +1,5 @@
 import { FC, useCallback, useMemo } from 'react'
+import { useNavigate } from 'react-router-dom'


The useNavigate hook is imported but not used in the code. Consider removing it if it's not needed to avoid unnecessary imports.

github-actions · 2025-07-22T10:54:22Z

src/apps/copilots/src/pages/copilot-requests/copilot-request-modal/CopilotRequestModal.tsx

@@ -18,6 +19,11 @@ interface CopilotRequestModalProps {

 const CopilotRequestModal: FC<CopilotRequestModalProps> = props => {
    const confirmModal = useConfirmationModal()
+    const navigate = useNavigate()
+
+    const editRequest = useCallback(() => {


The editRequest function is defined but not used within the component. Consider removing it if it's not needed or ensure it is invoked appropriately.

github-actions · 2025-07-22T10:54:25Z

src/apps/copilots/src/pages/copilot-requests/copilot-request-modal/CopilotRequestModal.tsx

                <>
-                    <Button primary onClick={confirmApprove} label='Approve Request' />
-                    <Button primary variant='danger' onClick={confirmReject} label='Reject Request' />
+                    <Button primary onClick={editRequest} label='Edit Request' className={styles.mrAuto} />


The className prop is added to the Edit Request button. Ensure that styles.mrAuto is defined in the styles and is necessary for the layout. If not, consider removing it to keep the code clean.

github-actions · 2025-07-22T10:54:27Z

src/apps/copilots/src/pages/copilot-requests/index.tsx

@@ -58,6 +58,10 @@ const CopilotTableActions: FC<{request: CopilotRequest}> = props => {
        navigate(copilotRoutesMap.CopilotRequestDetails.replace(':requestId', `${props.request.id}`))
    }, [navigate, props.request.id])

+    const editRequest = useCallback(() => {


Consider adding error handling in the editRequest function to manage potential navigation failures. This will improve the robustness of the function.

github-actions · 2025-07-22T10:54:29Z

src/apps/copilots/src/pages/copilot-requests/index.tsx

@@ -78,6 +82,14 @@ const CopilotTableActions: FC<{request: CopilotRequest}> = props => {
                        <IconSolid.EyeIcon className='icon-lg' />
                    </Tooltip>
                </div>
+                <div className={styles.viewRequestIcon} onClick={editRequest}>


The editRequest function is used here, but it's not clear from the diff if this function is defined or imported correctly. Please ensure that editRequest is defined and handles the edit action appropriately.

github-actions · 2025-07-22T10:54:34Z

src/apps/copilots/src/services/copilot-requests.ts

@@ -23,6 +23,7 @@ function copilotRequestFactory(data: any): CopilotRequest {
        createdAt: new Date(data.createdAt),
        data: undefined,
        opportunity: data.copilotOpportunity?.[0],
+        startDate: new Date(data.data?.startDate),


Ensure that data.data?.startDate is a valid date string before passing it to the Date constructor to avoid potential Invalid Date issues. Consider adding a check or using a date parsing library for better validation.

github-actions · 2025-07-22T10:54:36Z

src/apps/copilots/src/services/copilot-requests.ts

@@ -54,8 +55,8 @@ export type CopilotRequestResponse = SWRResponse<CopilotRequest, CopilotRequest>
 * @param {string} requestId - The unique identifier of the copilot request.
 * @returns {CopilotRequestResponse} - The response containing the copilot request data.
 */
-export const useCopilotRequest = (requestId: string): CopilotRequestResponse => {
-    const url = buildUrl(`${baseUrl}/copilots/requests/${requestId}`)
+export const useCopilotRequest = (requestId?: string): CopilotRequestResponse => {


The requestId parameter is now optional, but the url variable will be undefined if requestId is not provided. Ensure that the rest of the code handles this scenario appropriately to avoid potential runtime errors.

github-actions · 2025-07-22T10:54:39Z

src/apps/copilots/src/services/copilot-requests.ts

    const requestData = {
-        data: request,
+        data: { ...request, id: undefined },


The id property is being set to undefined in the request data. Ensure this is intentional and does not affect the server-side processing of the request.

github-actions · 2025-07-22T10:54:39Z

src/apps/copilots/src/services/copilot-requests.ts

    }

-    return xhrPostAsync(url, requestData, {})
+    return request.id ? xhrPatchAsync(url, requestData) : xhrPostAsync(url, requestData, {})


Consider handling potential errors from xhrPatchAsync and xhrPostAsync to ensure that any issues during the request are properly managed and communicated.

kkartunov

Looks good.

vas3a added 3 commits July 22, 2025 00:03

PM-1498 - support for opportunity title

e7deb62

typo

596ca36

PM-1499 - allow pms and admins to edit copilot requests

b784334

vas3a requested a review from kkartunov July 22, 2025 10:53

github-actions bot reviewed Jul 22, 2025

View reviewed changes

src/apps/copilots/src/copilots.routes.tsx Show resolved Hide resolved

src/apps/copilots/src/copilots.routes.tsx Show resolved Hide resolved

github-actions bot reviewed Jul 22, 2025

View reviewed changes

src/apps/copilots/src/pages/copilot-opportunity-list/index.tsx Show resolved Hide resolved

github-actions bot reviewed Jul 22, 2025

View reviewed changes

kkartunov approved these changes Jul 22, 2025

View reviewed changes

kkartunov merged commit ea3a141 into dev Jul 23, 2025
3 checks passed

		@@ -1,4 +1,5 @@
		import { FC, useCallback, useMemo } from 'react'
		import { useNavigate } from 'react-router-dom'

PM-1499 edit copilot request #1148

PM-1499 edit copilot request #1148

Uh oh!

Conversation

vas3a commented Jul 22, 2025

Related JIRA Ticket:

What's in this PR?

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

kkartunov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!