Add scorecard and phase ID checks to the reviewer checks #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| data: { | ||
| id: uuid(), | ||
| challengeId: activationChallenge.id, | ||
| scorecardId: '', |
There was a problem hiding this comment.
[❗❗ correctness]
The scorecardId is set to an empty string. Ensure that this is intentional and that the system can handle an empty scorecardId without causing issues. If a scorecardId is required, consider adding validation to prevent empty values.
| should.equal(e.message.indexOf('reviewers are missing required fields') >= 0, true) | ||
| return | ||
| } finally { | ||
| await prisma.challenge.delete({ where: { id: activationChallenge.id } }) |
There was a problem hiding this comment.
[maintainability]
The finally block deletes the activationChallenge regardless of whether the catch block is executed. Ensure that this deletion is intended in all cases, as it may affect test isolation or subsequent tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.