Added feature to copy clicked coordinates to clipboard#410
Open
yuiponpon wants to merge 10 commits intotoolsforexperiments:masterfrom
Open
Added feature to copy clicked coordinates to clipboard#410yuiponpon wants to merge 10 commits intotoolsforexperiments:masterfrom
yuiponpon wants to merge 10 commits intotoolsforexperiments:masterfrom
Conversation
Collaborator
|
Hello thank you for the feature! I tested it and it works great! once the mypy errors pass I'll merge it. One you have your first PR approved you will be able to trigger those tests yourself (I think...) |
Collaborator
|
@jenshnielsen I was looking for more details as to why this fails. The mypy failure does not have to do with anything yuiponpon modified. Do you know why this is happening? |
Collaborator
|
@marcosfrenkel Sorry for the late response. Mypy should now be passing again on master. @yuiponpon If you merge master into this branch hopefully resolve the typing issues |
Collaborator
|
@jenshnielsen Any clue why the checks are not running here? they are also not running in #413 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a feature to copy the coordinates clicked on Plottr's monitor to the clipboard.