Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added manual for customTag usage #63

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Added manual for customTag usage #63

wants to merge 12 commits into from
+64 −2

Conversation

Dominik-h-hub
Copy link

  • added manual "custom-tags.md" for customTag usage
  • added 2 new pictures for above mentioned manual

@Dominik-h-hub
Create custom-tags.md
e41645c
@Dominik-h-hub
Update custom-tags.md
5f8c963
@Dominik-h-hub
Update custom-tags.md
070fa7e
@Dominik-h-hub
Add files via upload
6ec365c
@Dominik-h-hub
Update custom-tags.md
305c013
@Dominik-h-hub
Update tonies-custom-json.md
bff7e8d 
Added explanations to reloading config via GUI and informations how to reference pictures stored via custom_img folder.
henryk86
henryk86 suggested changes Mar 9, 2025
View reviewed changes
Copy link
Contributor

@henryk86 henryk86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments in the code

@SciLor
Copy link
Contributor

SciLor commented Mar 9, 2025 •
edited
Loading

Toniebox is written Toniebox not "TonieBox".
Same with teddyCloud, stick to the variant used in the wiki.
Please check for typos.

@Dominik-h-hub
Update tonies-custom-json.md
4988118 
Fix PR comments, typos and change cusom_img reference to relative path.
@Dominik-h-hub
Update custom-tags.md
e4ae9b0
@henryk86
Copy link
Contributor

henryk86 commented Mar 9, 2025

I added some comments on the latest checked in file custom-tag.md

@Dominik-h-hub
Copy link
Author

@henryk86 and @SciLor : Thank you very much for your feedback today in the morning - i solved your comments, please review again now.

@henryk86
Copy link
Contributor

henryk86 commented Mar 9, 2025

Please check once more, you added some more mistakes unfortunately

@Dominik-h-hub
Copy link
Author

@henryk86 : Where can i see your new comments? I can only see your old comments right now. Thank you very much so far!

henryk86
henryk86 suggested changes Mar 10, 2025
View reviewed changes
@henryk86
Copy link
Contributor

@henryk86 : Where can i see your new comments? I can only see your old comments right now. Thank you very much so far!

Seems like I missed a final click and so the comments were not visible for you. Now they should hopefully

@Dominik-h-hub
Update tonies-custom-json.md
f8e9394 
added logo.png into suggested link
@Dominik-h-hub
Update custom-tags.md
0c0575d 
fixed latest comments on PR.
@Dominik-h-hub
Copy link
Author

@henryk86 : Ah now i can see them. I rechecked and resolved them. Please have a look now.

@Dominik-h-hub Dominik-h-hub requested a review from henryk86 March 10, 2025 19:35
@Dominik-h-hub
Update custom-tags.md
03ba2a8 
Update custom-tags.md
@Dominik-h-hub Dominik-h-hub requested a review from henryk86 March 10, 2025 20:26
@Dominik-h-hub Dominik-h-hub requested a review from SciLor March 11, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryk86 henryk86 henryk86 approved these changes

@SciLor SciLor Awaiting requested review from SciLor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dominik-h-hub @SciLor @henryk86