-
Notifications
You must be signed in to change notification settings - Fork 5
Gas comparison between wallets for simple transfers #537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the focused doc updates to standard/wallets/gas-benchmarks.mdx. A few wording, acronym, and formatting fixes are needed to align with the style guide and improve clarity. Findings (8)Medium (6)Click to expand[MEDIUM] Define “TON” on first mentionDescription: Suggestion: -This page provides gas consumption benchmarks for TON wallet contracts measured in both sandbox (local testing) and on-chain (testnet/mainnet) environments.
+This page provides gas consumption benchmarks for The Open Network (TON) wallet contracts measured in both sandbox (local testing) and on-chain (testnet/mainnet) environments.[MEDIUM] Throat-clearing opening sentenceDescription: Suggestion: -This page provides gas consumption benchmarks for TON wallet contracts measured in both sandbox (local testing) and on-chain (testnet/mainnet) environments.
+Gas consumption benchmarks for TON wallet contracts in sandbox (local testing) and on-chain (testnet/mainnet) environments.[MEDIUM] Define “VM” on first mentionDescription: Suggestion: -Gas costs vary between sandbox and on-chain due to different VM configurations, but the relative comparison between wallet versions remains consistent.
+Gas costs vary between sandbox and on-chain due to different virtual machine (VM) configurations, but the relative comparison between wallet versions remains consistent.[MEDIUM] Avoid informal abbreviation “msgs”Description: Suggestion: -| **V5** | 4,939 | 4,439 | +65-78% vs V3, supports gasless & batch (up to 255 msgs) |
+| **V5** | 4,939 | 4,439 | +65-78% vs V3, supports gasless and batch (up to 255 messages) |-- Single V5 batch (255 msgs) cheaper than 255 separate V3 externals
+- Single V5 batch (255 messages) cheaper than 255 separate V3 externals[MEDIUM] Missing code formatting and inconsistent version casing (methodology)Description: Suggestion: **Sandbox measurements:**
-- Framework: Blueprint + @ton/sandbox
-- Wallets: Official implementations from @ton/ton (V3R2, V4, V5R1) and ton-blockchain/highload-wallet-contract-v3
-- Test scenario: Simple transfer of [REDACTED] TON with PAY_GAS_SEPARATELY mode
+- Framework: Blueprint + `@ton/sandbox`
+- Wallets: Official implementations from `@ton/ton` (v3r2, v4, v5r1) and `ton-blockchain/highload-wallet-contract-v3`
+- Test scenario: Simple transfer of [REDACTED] TON with `PAY_GAS_SEPARATELY` mode[MEDIUM] Capitalize “TON Testnet” when used as proper nameDescription: Suggestion: -- Network: TON testnet
+- Network: TON TestnetLow (2)Click to expand[LOW] Link text casing inconsistent with existing docs (“Wallet V5” vs “Wallet v5”)Description: Suggestion: -- [Wallet V5](/standard/wallets/v5) — Latest wallet standard
+- [Wallet v5](/standard/wallets/v5) — Latest wallet standard[LOW] Vague “Similar” phrasing in resultsDescription: Suggestion: -- On-chain: Similar (comment doesn't affect compute gas)
+- On-chain: Approximately the same (comment text does not affect compute gas)-- On-chain: Similar
+- On-chain: Approximately the same |
|
In Highload v3 we must account for the forward fee in addition to the gas fee. Because the wallet’s flow executes two transactions, the forward fee will be about x2 that of a standard wallet. |
anton-trunov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@memearchivarius ping
|
To fix the formatting issues:
npx remark -o --silent --silently-ignore standard/wallets/gas-benchmarks.mdx |
|
To fix the formatting issues:
npx remark -o --silent --silently-ignore standard/wallets/gas-benchmarks.mdx |
|
To fix the formatting issues:
npx remark -o --silent --silently-ignore standard/wallets/gas-benchmarks.mdx |
|
@memearchivarius ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No documentation issues detected.
Co-authored-by: Novus Nota <[email protected]>
|
To fix the formatting issues:
npx remark -o --silent --silently-ignore standard/wallets/gas-benchmarks.mdx |
|
|
||
| ## Code examples | ||
|
|
||
| Check [gas-research](https://github.com/memearchivarius/gas-research) and [tolk-bench](https://github.com/ton-blockchain/tolk-bench) projects for code examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should move the scripts to https://github.com/ton-org/docs-examples, there should be no links to personal repos in the docs, unless it's some kind of SDK which happens to live there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, why tolk-bench in this article?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it's useful example of precise tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't want to provide more info than we need to, especially if it is not relevant to the case
|
@skywardboundd is going to take over this PR and re-do the tests |
|
Closing in favor of #1072 |
Closes #656.
We wanted to introduce this info in our original docs and here's a draft.