[#7] Adding private class/trait methods should generated a PATCH level.

Adding/Removing traits public/protected method should generate a MAJOR level.
Adding public/protected class methods should generate a MAJOR level.

Author: tomzx

docs/Ruleset.md

@@ -23,15 +23,15 @@ V010 | MAJOR | Class public method parameter changed
 V011 | MAJOR | Class protected method parameter changed
 V012 | MAJOR | *New public constructor (does not match supertype)*
 V013 | MAJOR | *New protected constructor (does not match supertype)*
+V015 | MAJOR | Class public method added
+V016 | MAJOR | Class protected method added
 V014 | MINOR | Class added
-V015 | MINOR | Class public method added *(display a notice that the method may overlap)* (MAJOR when not final)
-V016 | MINOR | Class protected method added *(display a notice that the method may overlap)* (MAJOR when not final)
 V017 | MINOR | *Final class public method added*
 V018 | MINOR | *Final class protected method added*
 V019 | MINOR | *Class public property added*
 V020 | MINOR | *Class protected property added*
-V021 | MINOR | Class protected method parameter changed *(MAJOR when not final)*
-V022 | MAJOR | *Final class protected method removed*
+V021 | MINOR | *Final class protected method parameter changed*
+V022 | PATCH | *Final class protected method removed*
 V023 | PATCH | [Final] Class public class method implementation changed
 V024 | PATCH | [Final] Class protected class method implementation changed
 V025 | PATCH | [Final] Class private class method implementation changed
@@ -69,19 +69,19 @@ V042 | MAJOR | Trait public method parameter changed
 V043 | MAJOR | Trait protected method parameter changed
 V044 | MAJOR | *New public constructor (does not match supertype)*
 V045 | MAJOR | *New protected constructor (does not match supertype)*
+V047 | MAJOR | Trait public method added
+V048 | MAJOR | Trait protected method added
+V049 | MAJOR | *Trait public property added*
+V050 | MAJOR | *Trait protected property added*
+V055 | MAJOR | *Trait private property added*
+V056 | MAJOR | *Trait private property removed*
+V057 | MAJOR | Trait private method added
+V058 | MAJOR | Trait private method removed
 V046 | MINOR | Trait added
-V047 | MINOR | Trait public method added *(display a notice that the method may overlap)* (MAJOR when not final)
-V048 | MINOR | Trait protected method added *(display a notice that the method may overlap)* (MAJOR when not final)
-V049 | MINOR | *Trait public property added*
-V050 | MINOR | *Trait protected property added*
 V051 | MINOR | *REMOVED*
 V052 | PATCH | Trait public method implementation changed
 V053 | PATCH | Trait protected method implementation changed
 V054 | PATCH | Trait private method implementation changed
-V055 | PATCH | *Trait private property added*
-V056 | PATCH | *Trait private property removed*
-V057 | PATCH | Trait private method added
-V058 | PATCH | Trait private method removed
 V059 | PATCH | Trait private method parameter changed
 V064 | PATCH | Trait public method parameter name changed
 V065 | PATCH | Trait protected method parameter name changed 

src/PHPSemVerChecker/Operation/ClassMethodAdded.php

@@ -19,9 +19,9 @@ class ClassMethodAdded extends ClassMethodOperation {
 	 * @var int
 	 */
 	protected $level = [
-		'class' => [Level::MINOR, Level::MINOR, Level::MINOR],
+		'class' => [Level::MAJOR, Level::MAJOR, Level::PATCH],
 		'interface' => [Level::MAJOR],
-		'trait' => [Level::MINOR, Level::MINOR, Level::MINOR],
+		'trait' => [Level::MAJOR, Level::MAJOR, Level::MAJOR],
 	];
 	/**
 	 * @var string

src/PHPSemVerChecker/Operation/ClassMethodRemoved.php

@@ -22,7 +22,7 @@ class ClassMethodRemoved extends ClassMethodOperation {
 	protected $level = [
 		'class' => [Level::MAJOR, Level::MAJOR, Level::PATCH],
 		'interface' => [Level::MAJOR],
-		'trait' => [Level::MAJOR, Level::MAJOR, Level::PATCH],
+		'trait' => [Level::MAJOR, Level::MAJOR, Level::MAJOR],
 	];
 	/**
 	 * @var string

tests/PHPSemVerChecker/Analyzer/ClassMethodAnalyzerTest.php

@@ -64,9 +64,9 @@ public function testV015ClassMethodAdded()
 		$analyzer = new ClassMethodAnalyzer('class');
 		$report = $analyzer->analyze($classBefore, $classAfter);
 
-		Assert::assertDifference($report, 'class', Level::MINOR);
-		$this->assertSame('Method has been added.', $report['class'][Level::MINOR][0]->getReason());
-		$this->assertSame('tmp::tmpMethod', $report['class'][Level::MINOR][0]->getTarget());
+		Assert::assertDifference($report, 'class', Level::MAJOR);
+		$this->assertSame('Method has been added.', $report['class'][Level::MAJOR][0]->getReason());
+		$this->assertSame('tmp::tmpMethod', $report['class'][Level::MAJOR][0]->getTarget());
 	}
 
 	public function testSimilarClassMethodSignature()

tests/PHPSemVerChecker/Analyzer/TraitMethodAnalyzerTest.php

@@ -56,9 +56,9 @@ public function testV047PublicClassMethodAdded()
 		$analyzer = new ClassMethodAnalyzer('trait');
 		$report = $analyzer->analyze($traitBefore, $traitAfter);
 
-		Assert::assertDifference($report, 'trait', Level::MINOR);
-		$this->assertSame('Method has been added.', $report['trait'][Level::MINOR][0]->getReason());
-		$this->assertSame('tmp::tmpMethod', $report['trait'][Level::MINOR][0]->getTarget());
+		Assert::assertDifference($report, 'trait', Level::MAJOR);
+		$this->assertSame('Method has been added.', $report['trait'][Level::MAJOR][0]->getReason());
+		$this->assertSame('tmp::tmpMethod', $report['trait'][Level::MAJOR][0]->getTarget());
 	}
 
 	public function testSimilarPublicClassMethodSignature()

tests/fixtures/after/FunctionParameterNameChanged.php

@@ -2,7 +2,7 @@
 
 namespace fixtures;
 
-function functionParameterChanged($someOtherParameterName)
+function functionParameterNameChanged($someOtherParameterName)
 {
 
 }

tests/fixtures/before/FunctionParameterNameChanged.php

@@ -2,7 +2,7 @@
 
 namespace fixtures;
 
-function functionParameterChanged($someParameter)
+function functionParameterNameChanged($someParameter)
 {
 
 }