Added more fixtures to test the new verifications.

tomzx · tomzx · commit 420297686582 · 2015-01-14T12:22:56.000-05:00
Updated Ruleset.md to better represent the current state of the verified ruleset.
diff --git a/docs/Ruleset.md b/docs/Ruleset.md
@@ -16,31 +16,31 @@ Code | Level | Rule
 -----|-------|-------
 V005 | MAJOR | Class removed
 V006 | MAJOR | Class public method removed
-V007 | MAJOR | *Class protected method removed*
+V007 | MAJOR | Class protected method removed
 V008 | MAJOR | *Class public property removed*
 V009 | MAJOR | *Class protected property removed*
 V010 | MAJOR | Class public method parameter changed
-V011 | MAJOR | *Class protected method parameter changed*
+V011 | MAJOR | Class protected method parameter changed
 V012 | MAJOR | *New public constructor (does not match supertype)*
 V013 | MAJOR | *New protected constructor (does not match supertype)*
 V014 | MINOR | Class added
 V015 | MINOR | Class public method added *(display a notice that the method may overlap)* (MAJOR when not final)
-V016 | MINOR | *Class protected method added* *(display a notice that the method may overlap)* (MAJOR when not final)
+V016 | MINOR | Class protected method added *(display a notice that the method may overlap)* (MAJOR when not final)
 V017 | MINOR | *Final class public method added*
 V018 | MINOR | *Final class protected method added*
 V019 | MINOR | *Class public property added*
 V020 | MINOR | *Class protected property added*
-V021 | MINOR | Class protected method parameter changed (MAJOR when not final)
-V022 | MAJOR | Final class protected method removed
+V021 | MINOR | Class protected method parameter changed *(MAJOR when not final)*
+V022 | MAJOR | *Final class protected method removed*
 V023 | PATCH | [Final] Class public class method implementation changed
-V024 | PATCH | [Final] Class *protected* class method implementation changed
-V025 | PATCH | [Final] Class *private* class method implementation changed
+V024 | PATCH | [Final] Class protected class method implementation changed
+V025 | PATCH | [Final] Class private class method implementation changed
 V026 | PATCH | *Class private property added*
 V027 | PATCH | *Class private property removed*
-V028 | PATCH | *Class private method added*
-V029 | PATCH | *Class private method removed*
+V028 | PATCH | Class private method added
+V029 | PATCH | Class private method removed
 V030 | PATCH | *Final class protected method added*
-V031 | PATCH | *Class private method parameter changed*
+V031 | PATCH | Class private method parameter changed
 V060 | PATCH | Class public method parameter name changed
 V061 | PATCH | Class protected method parameter name changed 
 V062 | PATCH | Class private method parameter name changed 
@@ -62,29 +62,31 @@ Code | Level | Rule
 -----|-------|-------
 V037 | MAJOR | Trait removed
 V038 | MAJOR | Trait public method removed
-V039 | MAJOR | *Trait protected method removed*
+V039 | MAJOR | Trait protected method removed
 V040 | MAJOR | *Trait public property removed*
 V041 | MAJOR | *Trait protected property removed*
 V042 | MAJOR | Trait public method parameter changed
-V043 | MAJOR | *Trait protected method parameter changed*
+V043 | MAJOR | Trait protected method parameter changed
 V044 | MAJOR | *New public constructor (does not match supertype)*
 V045 | MAJOR | *New protected constructor (does not match supertype)*
 V046 | MINOR | Trait added
 V047 | MINOR | Trait public method added *(display a notice that the method may overlap)* (MAJOR when not final)
-V048 | MINOR | *Trait protected method added* *(display a notice that the method may overlap)* (MAJOR when not final)*
+V048 | MINOR | Trait protected method added *(display a notice that the method may overlap)* (MAJOR when not final)
 V049 | MINOR | *Trait public property added*
 V050 | MINOR | *Trait protected property added*
-V051 | MINOR | *Trait protected method parameter changed (MAJOR when not final)*
-V052 | PATCH | Trait public trait method implementation changed
-V053 | PATCH | *Trait *protected* trait method implementation changed*
-V054 | PATCH | *Trait *private* trait method implementation changed*
+V051 | MINOR | *REMOVED*
+V052 | PATCH | Trait public method implementation changed
+V053 | PATCH | Trait protected method implementation changed
+V054 | PATCH | Trait private method implementation changed
 V055 | PATCH | *Trait private property added*
 V056 | PATCH | *Trait private property removed*
-V057 | PATCH | *Trait private method added*
-V058 | PATCH | *Trait private method removed*
-V059 | PATCH | *Trait private method parameter changed*
+V057 | PATCH | Trait private method added
+V058 | PATCH | Trait private method removed
+V059 | PATCH | Trait private method parameter changed
 V064 | PATCH | Trait public method parameter name changed
 V065 | PATCH | Trait protected method parameter name changed 
 V066 | PATCH | Trait private method parameter name changed 
 
-Method visibility changed
+# To classify
+
+* Method visibility changed
diff --git a/tests/fixtures/after/ClassMethodAdded.php b/tests/fixtures/after/ClassMethodAdded.php
@@ -4,8 +4,18 @@
 
 class ClassMethodAdded
 {
-	public function newMethod()
+	public function publicMethod()
 	{
 
 	}
-}
+
+	protected function protectedMethod()
+	{
+
+	}
+
+	private function privateMethod()
+	{
+
+	}
+}
diff --git a/tests/fixtures/after/ClassMethodImplementationChanged.php b/tests/fixtures/after/ClassMethodImplementationChanged.php
@@ -4,8 +4,18 @@
 
 class ClassMethodImplementationChanged
 {
-	public function newMethod()
+	public function publicMethod()
 	{
 		$x = 3;
 	}
-}
+
+	protected function protectedMethod()
+	{
+		$x = 3;
+	}
+
+	private function privateMethod()
+	{
+		$x = 3;
+	}
+}
diff --git a/tests/fixtures/after/ClassMethodParameterChanged.php b/tests/fixtures/after/ClassMethodParameterChanged.php
@@ -4,7 +4,17 @@
 
 class ClassMethodParameterChanged
 {
-	public function newMethod($someParameter)
+	public function publicMethod($someParameter)
+	{
+
+	}
+
+	protected function protectedMethod($someParameter)
+	{
+
+	}
+
+	private function privateMethod($someParameter)
 	{
 
 	}
diff --git a/tests/fixtures/after/ClassMethodParameterNameChanged.php b/tests/fixtures/after/ClassMethodParameterNameChanged.php
@@ -0,0 +1,21 @@
+<?php
+
+namespace fixtures;
+
+class ClassMethodParameterNameChanged
+{
+	public function publicMethod($someOtherParameterName)
+	{
+
+	}
+
+	protected function protectedMethod($someOtherParameterName)
+	{
+
+	}
+
+	private function privateMethod($someOtherParameterName)
+	{
+
+	}
+}
diff --git a/tests/fixtures/after/FunctionParameterChanged.php b/tests/fixtures/after/FunctionParameterChanged.php
diff --git a/tests/fixtures/after/FunctionParameterNameChanged.php b/tests/fixtures/after/FunctionParameterNameChanged.php
@@ -0,0 +1,8 @@
+<?php
+
+namespace fixtures;
+
+function functionParameterChanged($someOtherParameterName)
+{
+
+}
diff --git a/tests/fixtures/after/InterfaceMethodParameterChaged.php b/tests/fixtures/after/InterfaceMethodParameterChaged.php
diff --git a/tests/fixtures/after/InterfaceMethodParameterNameChaged.php b/tests/fixtures/after/InterfaceMethodParameterNameChaged.php
@@ -0,0 +1,8 @@
+<?php
+
+namespace fixtures;
+
+interface InterfaceMethodParameterNameChanged
+{
+	public function publicMethod($someOtherParameterName);
+}
diff --git a/tests/fixtures/after/TraitMethodAdded.php b/tests/fixtures/after/TraitMethodAdded.php
@@ -0,0 +1,21 @@
+<?php
+
+namespace fixtures;
+
+trait TraitMethodAdded
+{
+	public function publicMethod()
+	{
+
+	}
+
+	protected function protectedMethod()
+	{
+
+	}
+
+	private function privateMethod()
+	{
+
+	}
+}
diff --git a/tests/fixtures/after/TraitMethodImplementationChanged.php b/tests/fixtures/after/TraitMethodImplementationChanged.php
@@ -4,7 +4,17 @@
 
 trait TraitMethodImplementationChanged
 {
-	public function newMethod()
+	public function publicMethod()
+	{
+		$x = 3;
+	}
+
+	protected function protectedMethod()
+	{
+		$x = 3;
+	}
+
+	private function privateMethod()
 	{
 		$x = 3;
 	}
diff --git a/tests/fixtures/after/TraitMethodParameterChanged.php b/tests/fixtures/after/TraitMethodParameterChanged.php
@@ -4,7 +4,17 @@
 
 trait TraitMethodParameterChanged
 {
-	public function newMethod($someParameter)
+	public function publicMethod($someParameter)
+	{
+
+	}
+
+	protected function protectedMethod($someParameter)
+	{
+
+	}
+
+	private function privateMethod($someParameter)
 	{
 
 	}
diff --git a/tests/fixtures/after/TraitMethodParameterNameChanged.php b/tests/fixtures/after/TraitMethodParameterNameChanged.php
@@ -0,0 +1,21 @@
+<?php
+
+namespace fixtures;
+
+trait TraitMethodParameterNameChanged
+{
+	public function publicMethod($someOtherParameterName)
+	{
+
+	}
+
+	protected function protectedMethod($someOtherParameterName)
+	{
+
+	}
+
+	private function privateMethod($someOtherParameterName)
+	{
+
+	}
+}
diff --git a/tests/fixtures/before/ClassMethodImplementationChanged.php b/tests/fixtures/before/ClassMethodImplementationChanged.php
@@ -4,8 +4,18 @@
 
 class ClassMethodImplementationChanged
 {
-	public function newMethod()
+	public function publicMethod()
 	{
 		$x = 0;
 	}
-}
+
+	protected function protectedMethod()
+	{
+		$x = 0;
+	}
+
+	private function privateMethod()
+	{
+		$x = 0;
+	}
+}
diff --git a/tests/fixtures/before/ClassMethodParameterChanged.php b/tests/fixtures/before/ClassMethodParameterChanged.php
@@ -4,7 +4,17 @@
 
 class ClassMethodParameterChanged
 {
-	public function newMethod()
+	public function publicMethod()
+	{
+
+	}
+
+	protected function protectedMethod()
+	{
+
+	}
+
+	private function privateMethod()
 	{
 
 	}
diff --git a/tests/fixtures/before/ClassMethodParameterNameChanged.php b/tests/fixtures/before/ClassMethodParameterNameChanged.php
@@ -0,0 +1,21 @@
+<?php
+
+namespace fixtures;
+
+class ClassMethodParameterNameChanged
+{
+	public function publicMethod($someParameter)
+	{
+
+	}
+
+	protected function protectedMethod($someParameter)
+	{
+
+	}
+
+	private function privateMethod($someParameter)
+	{
+
+	}
+}
diff --git a/tests/fixtures/before/ClassMethodRemoved.php b/tests/fixtures/before/ClassMethodRemoved.php
@@ -4,8 +4,18 @@
 
 class ClassMethodRemoved
 {
-	public function newMethod()
+	public function publicMethod()
 	{
 
 	}
-}
+
+	protected function protectedMethod()
+	{
+
+	}
+
+	private function privateMethod()
+	{
+
+	}
+}
diff --git a/tests/fixtures/before/FunctionParameterNameChanged.php b/tests/fixtures/before/FunctionParameterNameChanged.php
@@ -0,0 +1,8 @@
+<?php
+
+namespace fixtures;
+
+function functionParameterChanged($someParameter)
+{
+
+}
diff --git a/tests/fixtures/before/InterfaceMethodParameterNameChanged.php b/tests/fixtures/before/InterfaceMethodParameterNameChanged.php
@@ -0,0 +1,8 @@
+<?php
+
+namespace fixtures;
+
+interface InterfaceMethodParameterNameChanged
+{
+	public function publicMethod($someParameter);
+}
diff --git a/tests/fixtures/before/TraitMethodImplementationChanged.php b/tests/fixtures/before/TraitMethodImplementationChanged.php
@@ -4,7 +4,17 @@
 
 trait TraitMethodImplementationChanged
 {
-	public function newMethod()
+	public function publicMethod()
+	{
+		$x = 0;
+	}
+
+	protected function protectedMethod()
+	{
+		$x = 0;
+	}
+
+	private function privateMethod()
 	{
 		$x = 0;
 	}
diff --git a/tests/fixtures/before/TraitMethodParameterChanged.php b/tests/fixtures/before/TraitMethodParameterChanged.php
diff --git a/tests/fixtures/before/TraitMethodParameterNameChanged.php b/tests/fixtures/before/TraitMethodParameterNameChanged.php
diff --git a/tests/fixtures/before/TraitMethodRemoved.php b/tests/fixtures/before/TraitMethodRemoved.php

Original file line number	Diff line number	Diff line change
`@@ -4,8 +4,18 @@`
`4`	`4`
`5`	`5`	`class ClassMethodAdded`
`6`	`6`	`{`
`7`		`- public function newMethod()`
	`7`	`+ public function publicMethod()`
`8`	`8`	`{`
`9`	`9`
`10`	`10`	`}`
`11`		`-}`
	`11`	`+`
	`12`	`+ protected function protectedMethod()`
	`13`	`+ {`
	`14`	`+`
	`15`	`+ }`
	`16`	`+`
	`17`	`+ private function privateMethod()`
	`18`	`+ {`
	`19`	`+`
	`20`	`+ }`
	`21`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,17 @@`
`4`	`4`
`5`	`5`	`class ClassMethodParameterChanged`
`6`	`6`	`{`
`7`		`- public function newMethod($someParameter)`
	`7`	`+ public function publicMethod($someParameter)`
	`8`	`+ {`
	`9`	`+`
	`10`	`+ }`
	`11`	`+`
	`12`	`+ protected function protectedMethod($someParameter)`
	`13`	`+ {`
	`14`	`+`
	`15`	`+ }`
	`16`	`+`
	`17`	`+ private function privateMethod($someParameter)`
`8`	`18`	`{`
`9`	`19`
`10`	`20`	`}`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,8 @@ @@
 +<?php
++
 +namespace fixtures;
++
 +function functionParameterChanged($someOtherParameterName)
 +{
++
 +}