Open
Conversation
…to seq_len for prompt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added a simple 2x MLP to encode raw NMR instead of interpolating them to 1k. both NMRs are projected to memory_dim and concatenated over seq_len.
Transformer decoder should be ok, as uses whatever seq_len comes in.
note this doesn't cntain info about the multiplets (for now), plus the projection is pretty sharp, especially for low embed_dim (maybe should be more bottleneck than expanding dimension MLP...). note that this way we use the full embed_dim for IR, hence modalities are less separated between different attention heads.
setting use_mlp_for_nmr=False gives back regular functionality.
maybe a next step could be validating the effect of regular vs this. eventually we can:
-keep convnext, change the backbone HPs to downsample more and get around regular seq_len as the IR, then pad and concatenate as usual over embed_dim.