This repository was archived by the owner on Dec 17, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 51
1. Profile image added to NavBar #57
Open
sohailqureshi
wants to merge
28
commits into
tommcclean:master
Choose a base branch
from
sohailqureshi:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohailqureshi
commented
Feb 3, 2019
- Framework-Nav.css updated for profile image
2. Framework-Nav.css updated for profile image
Microsoft.AspNet.Identity.EntityFramework in Entities project
…dencies - but not yet implemented for general use
2. Get/Fetch methods amended to access base methods 3. Services project amended to inherit from base repository
(Not fully implemented)
All tables now reference EF Identity - woo hoo!!
2. fixed css for checkboxes 3. mo=inor changes from previous framework upgrade
2. Added Captcha to regitration page 3. Added Remember Me to Login page 4. All Projects now running on EF 4.6.1
HTML templated emails added for password/registration actions Captcha issues fixed
2. Minor css changes
zakwillis
reviewed
Feb 25, 2019
zakwillis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep up the good work. Off skiing shortly.
Owner
|
Hi Sohail, this PR is huge at 901 file changes. Can you consolidate the changes required to add the profile image to the navbar without including refactorings across the board and shoot that PR over? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.