treating multiple module paths separately so all can be synchronized … #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to the target filesystem and remain relative
Collaborator
|
Out of curiosity. What version of puppet are you using? I haven't used this since the 2.7 days. |
Contributor
Author
|
Puppet 3.8.3 on the master. Incidentally, I gave up on puppet-push because it is fundamentally incompatible with puppetdb which I use for the normal pull hosts. With puppetdb enabled, facts never get loaded from yaml files, and I found no easy hack to load them into postgres... I wound up doing an ssh tunnel instead. |
Collaborator
|
Yeah, that was one of my issues as well, you'd have to be able to push the yaml facts into puppetdb and then let the master evaluate them, it's all coming back to me now. I tried to do it, but it was starting to feel very hacky :) Thanks for the patches anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to the target filesystem and remain relative.
Current code does not handle the following:
Let's say I'm using environment "X" and have the following files:
Manifests will refer to the files as follows, without specifying env's:
The rsync action should copy paths from both locations, removing "/etc/puppet/environments/X/modules/" and "/etc/puppet/modules/" from the file paths. Now the rewritten paths will be correct (/var/lib/puppet-push/modules/MODULE_NAME.....)
Currently the code creates /var/lib/puppet-push/etc/puppet/modules..... which is incorrect.