Answer:5 #1382
Open
Answer:5 #1382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomalaforge
added
sponsor
tomalaforge
reviewed
Oct 29, 2025
| vertical-align: middle; | ||
| margin-left: 4px; | ||
| } | ||
| `, |
There was a problem hiding this comment.
nitpick: always use changedetection.onpush That's an easy win
tomalaforge
reviewed
Oct 29, 2025
| @for (todo of todos; track todo.id) { | ||
| {{ todo.title }} | ||
| <button (click)="update(todo)">Update</button> | ||
| <app-loader></app-loader> |
There was a problem hiding this comment.
you have a global loader.
What is I want a loader located at the todo component level when I update the todo, or delete it ?
There was a problem hiding this comment.
I implemented two kinds of loaders:
the global one:
<app-loader></app-loader>
and at the todo level as well:
@if (isProccessing()) { <span class="inline-spinner"> <mat-spinner [diameter]="16" [attr.data-testid]="'todo-spinner-' + todo().id" /> </span> }
tomalaforge
reviewed
Oct 29, 2025
| await waitForElementToBeRemoved(() => screen.getByTestId('todo-spinner-2')); | ||
| expect(screen.getAllByTestId('todo-item').length).toBe(1); | ||
| }); | ||
| }); |
|
i'm not very familiar with the signal store, I'm pro tanstack 😅 but nice code and nice tests. great job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.