Also also prevents falling back to random card by moving epoch method #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tooClose function will always hit if you draw too many early cards in the 1800-2020 range When the tooClose function rules out all cards, the game defaults to drawing a random card from the deck without any other failsafes. One of the failsafes in tooClose is to ensure cards are at least 1 year away from any existing card. Without this failsafe, we can have ties (which fail on a coinflip) and in some cases even a duplicate card being drawn. We also lose all the other balancing effects of avoidPeople and splitting cards into three different periods.
This was referenced Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deals with fallback issue discussed in #121 and #122, but allows us to do things in one pass by massively reducing the chance of covering a whole epoch.
Does this by simply shifting the year from which the most recent era is measured for the few most problematic rounds.
Otherwise preserves the
tooClosefunction as originally describedThis solution provides a mathematical guarantee if we assume there is at least one card for every year (which is either not true or at least not guaranteed to be true forever).
Closes #103, addresses same as #122