Use the new places api compat library #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the updates, would take a look shortly. |
|
Please look at this PR, we are having issue right now with the old API. |
|
Hi again @bcgilliom, I went for a more permanent update and one that would work for the foreseeable future on both platforms - iOS and Android - please see 198 . Thanks for your contributions, would be closing this PR now but please make other contributions in the future! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seemed like the path of least resistance...
Use implementation/compileOnly
Use the google paces compat library
check for location permission at runtime fur current place call
I have not tested the UI parts of this, only the direct calls - and really just the happy path there... If I encounter any problems during dev, I'll try to update this PR