Fix reconnection state management#26
Merged
Merged
Conversation
the connected channel was one-shot — after first close, reconnection events couldn't signal properly. replaced with firstConn channel for initial wait only, atomic ready bool as source of truth for ongoing state. also: - debounce disconnect events (only log on connected→disconnected) - track disconnect timestamp for better error messages - context-aware errors: "reconnecting" vs "connection lost" vs "expired" - cap get_messages limit to 500 to prevent OOM - add SQLite indexes on push_name and media_type closes #25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the "WhatsApp is reconnecting" error that users hit when the connection drops and auto-reconnects.
Root cause
The
connectedchannel was a one-shot signal — after it closed on first connect, reconnection events couldn't update state properly. Tools kept returning "reconnecting" even after WhatsApp successfully reconnected.Fix
connectedchannel withfirstConn(initial wait only)readyatomic bool is the sole source of truth for connection stateAlso
get_messageslimit to 500 (prevents OOM on huge requests)push_nameandmedia_typefor faster queriesCloses #25
Test plan
go test ./... -vpassesget_messageswith limit=999999 caps at 500