Fix async caching of None return values#26
Merged
Merged
Conversation
Added _probe() method to both CachedFunction and SharedCachedFunction that returns (hit: bool, value) instead of Option — distinguishes cached None from cache miss. AsyncCachedFunction now uses _probe() instead of get(), fixing the bug where functions returning None were never cached on the async path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
toloco
force-pushed
the
async-single-flight
branch
from
503a677 to
6743551
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_probe(*args, **kwargs) -> (bool, value)to bothCachedFunctionandSharedCachedFunctionin Rust — returns(True, value)on hit,(False, None)on missAsyncCachedFunctionnow uses_probe()instead ofget(), correctly distinguishing cachedNonefrom a cache missget()unchanged for backwards compatibilityPreviously, async-wrapped functions returning
Nonewere never cached becauseget()returnsNonefor both "miss" and "cached None" (PyO3'sOption<Py<PyAny>>conflates them).Test plan
test_async_none_return_value— memory backend, assertcall_count == 1after two callstest_async_none_return_value_shared— shared backend, same assertion🤖 Generated with Claude Code