Add async single-flight coalescing (dogpile prevention)#25
Merged
Conversation
When multiple async coroutines miss the cache for the same key concurrently, only one computes the result — the rest await an asyncio.Event and reuse it. Handles error recovery (waiters retry) and cancellation cleanly. Closes #16 (single-flight portion; non-blocking waits deferred). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asyncio.Eventand reuse itCloses #16 (single-flight portion; non-blocking waits deferred as low-priority).
Test plan
test_async_single_flight— 10 concurrent coroutines, assert exactly 1 computationtest_async_single_flight_different_keys— no false coalescing across keystest_async_single_flight_error_recovery— leader fails, waiters recovertest_async_single_flight_cancellation— leader cancelled, waiters recovertest_async_single_flight_shared— works with shared backendtest_async_concurrentassertion tightened from>= 3to== 3🤖 Generated with Claude Code