implement valuable for Path

implement valuable for Path instead of &Path, in order to support types like Box<Path> Signed-off-by: Eliad Peller <[email protected]>
tokio-rs · Mar 29, 2023 · 47e8fe5 · 47e8fe5
1 parent 1021649
commit 47e8fe5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/tests/tests/ui/not_valuable.stderr b/tests/tests/ui/not_valuable.stderr
@@ -11,11 +11,11 @@ error[E0277]: the trait bound `S: Valuable` is not satisfied
             &T
             &[T]
             &mut T
-            &std::path::Path
             &str
             ()
             (T0, T1)
             (T0, T1, T2)
+            (T0, T1, T2, T3)
           and $N others
   = note: required for `Option<S>` to implement `Valuable`
 
@@ -31,11 +31,11 @@ error[E0277]: the trait bound `S: Valuable` is not satisfied
              &T
              &[T]
              &mut T
-             &std::path::Path
              &str
              ()
              (T0, T1)
              (T0, T1, T2)
+             (T0, T1, T2, T3)
            and $N others
    = note: required for `Option<S>` to implement `Valuable`
 
@@ -52,11 +52,11 @@ error[E0277]: the trait bound `S: Valuable` is not satisfied
              &T
              &[T]
              &mut T
-             &std::path::Path
              &str
              ()
              (T0, T1)
              (T0, T1, T2)
+             (T0, T1, T2, T3)
            and $N others
    = note: required for `Option<S>` to implement `Valuable`
    = note: 1 redundant requirement hidden
@@ -75,11 +75,11 @@ error[E0277]: the trait bound `S: Valuable` is not satisfied
              &T
              &[T]
              &mut T
-             &std::path::Path
              &str
              ()
              (T0, T1)
              (T0, T1, T2)
+             (T0, T1, T2, T3)
            and $N others
    = note: required for `Option<S>` to implement `Valuable`
    = note: 1 redundant requirement hidden

diff --git a/valuable/src/valuable.rs b/valuable/src/valuable.rs
@@ -299,7 +299,7 @@ impl Valuable for alloc::string::String {
 }
 
 #[cfg(feature = "std")]
-impl Valuable for &std::path::Path {
+impl Valuable for std::path::Path {
     fn as_value(&self) -> Value<'_> {
         Value::Path(self)
     }