-
Notifications
You must be signed in to change notification settings - Fork 846
docs: backport favicon to the main branch
#3351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
main branch
486a252 to
715c9e0
Compare
A PR to make the docs extra swish via a favicon for the browser tab! Before  After  (cherry picked from commit f841b57)
715c9e0 to
aea2f88
Compare
Contributor
Author
|
@hds This is now rebased and up-to-date with the current |
hds
approved these changes
Nov 20, 2025
Contributor
hds
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
hds
added a commit
that referenced
this pull request
Nov 24, 2025
# 0.1.35 (November 24, 2025) ### Added - Switch to unconditional `no_std` ([#3323]) - Improve code generation at trace points significantly ([#3398]) ### Fixed - Add missing `dyn` keyword in `Visit` documentation code sample ([#3387]) ### Documented - Add favicon for extra pretty docs ([#3351]) [#3323]: https://github.com/tokio-rs/tracing/pull/#3323 [#3351]: https://github.com/tokio-rs/tracing/pull/#3351 [#3387]: https://github.com/tokio-rs/tracing/pull/#3387 [#3398]: https://github.com/tokio-rs/tracing/pull/#3398
hds
added a commit
that referenced
this pull request
Nov 24, 2025
# 0.1.35 (November 24, 2025) ### Added - Switch to unconditional `no_std` ([#3323]) - Improve code generation at trace points significantly ([#3398]) ### Fixed - Add missing `dyn` keyword in `Visit` documentation code sample ([#3387]) ### Documented - Add favicon for extra pretty docs ([#3351]) [#3323]: https://github.com/tokio-rs/tracing/pull/#3323 [#3351]: https://github.com/tokio-rs/tracing/pull/#3351 [#3387]: https://github.com/tokio-rs/tracing/pull/#3387 [#3398]: https://github.com/tokio-rs/tracing/pull/#3398
hds
added a commit
that referenced
this pull request
Nov 26, 2025
# 0.1.35 (November 26, 2025) ### Added - Switch to unconditional `no_std` ([#3323]) - Improve code generation at trace points significantly ([#3398]) ### Fixed - Add missing `dyn` keyword in `Visit` documentation code sample ([#3387]) ### Documented - Add favicon for extra pretty docs ([#3351]) [#3323]: https://github.com/tokio-rs/tracing/pull/#3323 [#3351]: https://github.com/tokio-rs/tracing/pull/#3351 [#3387]: https://github.com/tokio-rs/tracing/pull/#3387 [#3398]: https://github.com/tokio-rs/tracing/pull/#3398
hds
added a commit
that referenced
this pull request
Nov 26, 2025
# 0.1.35 (November 26, 2025) ### Added - Switch to unconditional `no_std` ([#3323]) - Improve code generation at trace points significantly ([#3398]) ### Fixed - Add missing `dyn` keyword in `Visit` documentation code sample ([#3387]) ### Documented - Add favicon for extra pretty docs ([#3351]) [#3323]: https://github.com/tokio-rs/tracing/pull/#3323 [#3351]: https://github.com/tokio-rs/tracing/pull/#3351 [#3387]: https://github.com/tokio-rs/tracing/pull/#3387 [#3398]: https://github.com/tokio-rs/tracing/pull/#3398
hds
added a commit
that referenced
this pull request
Nov 26, 2025
# 0.1.35 (November 26, 2025) ### Added - Switch to unconditional `no_std` ([#3323]) - Improve code generation at trace points significantly ([#3398]) ### Fixed - Add missing `dyn` keyword in `Visit` documentation code sample ([#3387]) ### Documented - Add favicon for extra pretty docs ([#3351]) [#3323]: https://github.com/tokio-rs/tracing/pull/#3323 [#3351]: https://github.com/tokio-rs/tracing/pull/#3351 [#3387]: https://github.com/tokio-rs/tracing/pull/#3387 [#3398]: https://github.com/tokio-rs/tracing/pull/#3398
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #1033 to the
mainbranch.This should supersede #3318 if removing the favicon was not desired.