Implemented io-uring Op<Statx> and applied to read_uring and fs::try_exists#8080
Merged
Conversation
asder8215
commented
Apr 21, 2026
mattiapitossi
added
A-tokio
asder8215
force-pushed
the
io-uring-metadata
branch
3 times, most recently
from
ff8130b to
dd9a2c3
Compare
Contributor
Author
|
Any reason why 
|
Daksh14
reviewed
Apr 22, 2026
Member
|
The compilation error is probably related to whether the build is using gnu or musl libc. See rust-lang/rust#154981 with similar issue. |
asder8215
force-pushed
the
io-uring-metadata
branch
from
dd9a2c3 to
b474ac9
Compare
martin-g
reviewed
Apr 27, 2026
asder8215
force-pushed
the
io-uring-metadata
branch
from
b474ac9 to
4e5c5d3
Compare
asder8215
force-pushed
the
io-uring-metadata
branch
from
4e5c5d3 to
0d20ca6
Compare
asder8215
force-pushed
the
io-uring-metadata
branch
from
f7932c4 to
1685fe0
Compare
asder8215
force-pushed
the
io-uring-metadata
branch
2 times, most recently
from
90a1824 to
fcb9a10
Compare
asder8215
force-pushed
the
io-uring-metadata
branch
2 times, most recently
from
5183b76 to
5824fc1
Compare
Contributor
Author
|
Not sure what to make out of the failing check: Don't think that's due to this PR. |
Daksh14
reviewed
Jun 2, 2026
Daksh14
reviewed
Jun 2, 2026
asder8215
commented
Jun 4, 2026
asder8215
force-pushed
the
io-uring-metadata
branch
2 times, most recently
from
bd7c32f to
7a9e197
Compare
Contributor
Author
|
Is there anything else in this PR that needs to be modified? Or does everything look good? |
asder8215
force-pushed
the
io-uring-metadata
branch
from
7a9e197 to
9324bbe
Compare
…hutdown, stating multiple files, ELOOP, ENAMETOOLONG, EACCES
…statx is supported on 1.25+ musl, and MSRV that uses 1.25 on all *-linux-musl platforms is 1.93
…ble on Linux <5.1, removed stat permission denied test case since it doesn't work on Linux 4.19
… in statx operation, use assert pending in cancel ops
…on platforms that don't support io_uring, removed unnecessary comments, and added TODO on symlink_metadata for when Metadata::from_statx is stabilized
… fd leak test, and removed cfg_io_uring gates (localized the feature gate to the pertinent part of the code that uses it in read_uring)
asder8215
force-pushed
the
io-uring-metadata
branch
from
9324bbe to
3a24159
Compare
mattiapitossi
approved these changes
Jun 12, 2026
Daksh14
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This builds up on vrtgs PR in their attempt of implementing
Statxfor io-uring and apply it tofs::try_exists. I usedlibcinstead oflinux-raw-sysfor theStatximplementation, tried to preserve more of how the original code (prior to vrtgs' changes) looked in certain files. There are some inlining done for the metadata functions forStatxbecause I thought the body of the code in these functions were pretty small and didn't seem to involve generics (let me know if I should remove that). Some other review comments mentioned in review of vrtgs' PR is addressed such as safety comments, inlining for thetry_exists_uring, avoiding usingCStringliterals, etc.To note, this is my first time contributing to Tokio, so let me know if there's anything that I'm doing incorrectly or if I missed something as per procedure here. Let me know if I should also squash some commits as well.
ccing @Daksh14 since I got to working on this PR per him sharing vrtgs' PR with me.