Skip to content

#7168: Add tokio_test::sink_mock #7190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

barafael
Copy link
Contributor

@barafael barafael commented Mar 2, 2025

Motivation

StreamMock exists, SinkMock should arguably exist.

Solution

SinkMock queues up actions. On drop, if actions remain, it panics.

@github-actions github-actions bot added the R-loom-sync Run loom sync tests on this PR label Mar 2, 2025
@maminrayej maminrayej added the A-tokio-test Area: The tokio-test crate label Mar 2, 2025
@barafael barafael changed the title Fix #7168: Add tokio_test::sink_mock fix #7168: Add tokio_test::sink_mock Mar 2, 2025
@barafael barafael changed the title fix #7168: Add tokio_test::sink_mock #7168: Add tokio_test::sink_mock Mar 2, 2025
@ADD-SP
Copy link
Member

ADD-SP commented Jul 30, 2025

Hi @barafael , any update about this PR? If you are no longer working on it, I'd like to close this PR.

@barafael
Copy link
Contributor Author

Alright, go ahead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio-test Area: The tokio-test crate R-loom-sync Run loom sync tests on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants