Extension: Implement OptionalFromRequestParts trait
#3157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
force-pushed
the
optional-extension
branch
from
65b1d47 to
fda95fb
Compare
|
(missing changelog entry though) |
added |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It was previously possible to use
Option<Extension<T>>as an extractor, but with axum 0.8 we seem to have lost that functionality.Solution
This PR implements the
OptionalFromRequestPartstrait for theExtensionwrapper struct, restoring the previous behavior.The PR also adds a basic test for the extraction behavior, since it seems that we were missing this until now.