Make ConnectInfo work with ListenerExt::tap_io #3059
Merged
+50
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
changed the title
jplatte
force-pushed
the
jplatte/fix-3056
branch
from
23864cd to
0119179
Compare
mladedav
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3056.
I tried various ways of making the existing tokio-feature-flagged
Connectedimpl generic overListenerinstead. It worked but unfortunately stopped the legitConnectedimpl in the UDS example from compiling due to coherence. I could bypass that with a dummy generic parameter, but I don't think it's worth it.