Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): mobile at menu #8727

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

L-Sun
Copy link
Contributor

@L-Sun L-Sun commented Nov 7, 2024

Copy link

graphite-app bot commented Nov 7, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@L-Sun L-Sun added the blocked PR is disallowed to merge due to some reasons label Nov 7, 2024 — with Graphite App
@github-actions github-actions bot added mod:infra Environment related issues and discussions app:core labels Nov 7, 2024
Copy link
Contributor Author

L-Sun commented Nov 7, 2024

@L-Sun L-Sun marked this pull request as ready for review November 7, 2024 03:23
@L-Sun L-Sun marked this pull request as draft November 7, 2024 03:23
@L-Sun L-Sun changed the title feat(blocks): mobile at menu feat(core): mobile at menu Nov 7, 2024
@L-Sun L-Sun changed the title feat(core): mobile at menu feat(mobile): mobile at menu Nov 7, 2024
Copy link

nx-cloud bot commented Nov 7, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5f40fbc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.21%. Comparing base (c1ece15) to head (5f40fbc).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8727      +/-   ##
==========================================
- Coverage   70.22%   70.21%   -0.01%     
==========================================
  Files         546      546              
  Lines       33746    33746              
  Branches     3026     3026              
==========================================
- Hits        23697    23695       -2     
- Misses       9688     9690       +2     
  Partials      361      361              
Flag Coverage Δ
server-test 77.18% <ø> (ø)
unittest 45.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@L-Sun L-Sun force-pushed the l-sun/feat/mobile-linked-doc-widget branch from 559fc7c to 4ccd3a1 Compare November 8, 2024 08:35
@L-Sun L-Sun marked this pull request as ready for review November 8, 2024 08:35
@L-Sun L-Sun force-pushed the l-sun/feat/mobile-linked-doc-widget branch from 4ccd3a1 to c89cd88 Compare November 8, 2024 09:26
@L-Sun L-Sun removed the blocked PR is disallowed to merge due to some reasons label Nov 8, 2024
Copy link

graphite-app bot commented Nov 8, 2024

Merge activity

@EYHN EYHN force-pushed the l-sun/feat/mobile-linked-doc-widget branch from c89cd88 to 5f40fbc Compare November 8, 2024 11:06
@graphite-app graphite-app bot merged commit 5f40fbc into canary Nov 8, 2024
46 checks passed
@graphite-app graphite-app bot deleted the l-sun/feat/mobile-linked-doc-widget branch November 8, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:infra Environment related issues and discussions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants