feat: Add RSS for affine.pro #165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@pengx17 Please check this PR and merge the same. If the code is upto ur standards. It can be accessed by website_url/rss.xml |
lawvs
requested changes
Sep 17, 2024
pengx17
requested changes
Sep 17, 2024
There was a problem hiding this comment.
Thanks for your contribution!
Some changes that need to be made before merging:
- All files in content are static thus there is no need to have a dynamic API handler for RSS. Can you instead write a new script in
/generationand run it in github action instead? - No need to parse file with gray-matter again. All content's metadata is already parsed and in json format.
- I think you can just generate RSS for the blog files, excluding the templates and changelog.
|
Okay give me some time and I will do the requested changes ASAP. Sorry for the delay Sorry for the bad PR , new to open source |
asad0206
force-pushed
the
rss-asad-branch
branch
from
f8100d5
to
849315f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : #143
-Added RSS support for the website
Utilized RSS node js package which is a lightweight and independent package
You can see the example ss attached.
Please check the Pull Request and allow for the merge, In case of any issue please contact me. Thank you!