Final Review for chapter 2 & 3 #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_This PR is still a work in progress and not ready for review. Please wait 1-3 more days. Thank you!_ Adding the changes that came from the final review during Chapter 2 & 3 meeting. During the call and the next two weeks, the changes were included using this [this doc]https://docs.google.com/document/d/1XrOGcbIeqx0T0-05PIBqPDhz9yMZgRd3b3yBJFy5jAE/edit?usp=sharing Contributors in this PR: - Alice Sowerby - Zhiqian Yu - Jari Koivisto - Cornelius Schumacher - Ana Jiménez These people are already acknowledged in the OSPO Book contributors section. Nice work and thank you! Signed-off-by: Ana Jimenez Santamaria <[email protected]>
✅ Deploy Preview for ospomindmap canceled.
|
✅ Deploy Preview for ospobook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Ana Jimenez Santamaria <[email protected]>
Signed-off-by: Ana Jimenez Santamaria <[email protected]>
Signed-off-by: Ana Jimenez Santamaria <[email protected]>
Signed-off-by: Ana Jimenez Santamaria <[email protected]>
Signed-off-by: Ana Jimenez Santamaria <[email protected]>
anajsana
changed the title
koozz
approved these changes
Jul 8, 2024
Signed-off-by: Ana Jimenez Santamaria <[email protected]>
Signed-off-by: Ana Jimenez Santamaria <[email protected]>
alice-sowerby
requested changes
Jul 23, 2024
anajsana
commented
Jul 23, 2024
Signed-off-by: Ana Jimenez Santamaria <[email protected]>
Signed-off-by: Ana Jimenez Santamaria <[email protected]>
Signed-off-by: Ana Jimenez Santamaria <[email protected]>
Signed-off-by: Ana Jimenez Santamaria <[email protected]>
Signed-off-by: Ana Jimenez Santamaria <[email protected]>
|
changes made based on your comments @alice-sowerby ! please let me know if it's OK to merge now |
alice-sowerby
requested changes
Jul 23, 2024
Signed-off-by: Ana Jimenez Santamaria <[email protected]>
@alice-sowerby comment reviewed and changes made! |
|
@anajsana looks good to me |
|
Thanks all! merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is still a work in progress and not ready for review. Please wait 1-3 more days. Thank you!
Adding the changes that came from the final review during Chapter 2 & 3 meeting. During the call and the next two weeks, the changes were included using this this doc
Contributors in this PR:
These people are already acknowledged in the OSPO Book contributors section.
Nice work and thank you!