#108: Sidebar/108 #120
Open
#108: Sidebar/108 #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for todaytheylearned ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
shinkeonkim
reviewed
Mar 26, 2022
Comment on lines
28
to
25
| const setArr = []; | ||
| const [tagArr, setTagArr] = useState([]); |
Comment on lines
-29
to
+31
| {location.pathname === '/' ? <SideBar /> : null} | ||
| {location.pathname === '/' || location.pathname.slice(0, 8) === '/article' ? ( | ||
| <SideBar /> | ||
| ) : null} |
minjj0905
previously approved these changes
Mar 28, 2022
cychann
added
👏 Merge Needed
cychann
added
👀 In review
shinkeonkim
reviewed
Mar 29, 2022
Comment on lines
28
to
26
| const setArr = []; | ||
| const [tagsArr, setTagsArr] = useState([]); | ||
|
|
There was a problem hiding this comment.
p5: tags, setTags 로 하자는거였는뎀 ㅠ
There was a problem hiding this comment.
그냥 봐도 array인데 arr을 명시하는건 너무 이상함다
There was a problem hiding this comment.
아앗 그냥 tags.. 다시 커밋했습니당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용