Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#118: bug/search #119

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

#118: bug/search #119

wants to merge 1 commit into from

Conversation

cychann
Copy link
Member

@cychann cychann commented Mar 23, 2022

작업 내용

@cychann cychann added 🐛 Bug Something isn't working 👀 In review 리뷰 요청중인 상태 labels Mar 23, 2022
@cychann cychann self-assigned this Mar 23, 2022
@netlify
Copy link

netlify bot commented Mar 23, 2022

Deploy Preview for todaytheylearned ready!

Name Link
🔨 Latest commit 00c0bf5
🔍 Latest deploy log https://app.netlify.com/sites/todaytheylearned/deploys/623aa05cf5286f00085ca6eb
😎 Deploy Preview https://deploy-preview-119--todaytheylearned.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cychann cychann changed the title bug/search #118: bug/search Mar 25, 2022
Comment on lines +215 to +219
if (searchShow) {
inputRef.current.disabled = true;
} else {
inputRef.current.disabled = false;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inputRef.current.disabled = serachShow;

로 분기없이 가능할것같아요

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오..간결하게 감사합니다 👍

Copy link
Contributor

@soyekwon soyekwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 잘 봤습니다아

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working 👀 In review 리뷰 요청중인 상태
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants