update readme #21
update readme #21
Conversation
README.md
Outdated
|
|
||
| 1. Ensure you have a working toolchain available: | ||
| ```bash | ||
| ./build_examples.sh |
There was a problem hiding this comment.
Technically, this step is not required. The purpose of build_examples.sh is to be run by Travis CI in order to make sure that all examples compile.
torfmaster
left a comment
torfmaster
left a comment
There was a problem hiding this comment.
Thanks for the changes! I added some ideas how one could make the instructions more precise.
README.md
Outdated
|
|
||
| 1. Ensure you have a working toolchain available: | ||
| ```bash | ||
| ./build_examples.sh |
There was a problem hiding this comment.
./run_example.sh also builds the examples
README.md
Outdated
| 4. Now you should be able to build with: | ||
|
|
||
| `xargo build --target thumbv7em-tock-eabi` | ||
| ### Note! Do not use rustc-1.26! |
There was a problem hiding this comment.
I think you should not fix the version of the compiler at all. This should be managed by the toolchain file.
README.md
Outdated
| 2. Get a copy of this toolchain, in this repo's root: | ||
| ```bash | ||
| ./run_example.sh blink | ||
| ``` |
There was a problem hiding this comment.
One could notice here that due to behavior of the tockloader the parameters passed to tockloader in the run_example script only work for the nrf52dk, currently. At least as far as I can judge.
|
Updated now that #18 is merged. |
Woyten
left a comment
Woyten
left a comment
There was a problem hiding this comment.
LGTM. If nobody has anything to add, I will merge this very soon.
|
@bradjc Can this branch be deleted? |
|
@Woyten I think it's fine to always delete branches for merged branches (And generally I like the idea of not using branches on the main repo for PRs, but I've been loosing that battle... :/ ) |
|
I totally agree. So I'll do what needs to be done! 😉 |
Current directions don't work.