fix: Supporting two argument flavor of REPLACE function in Snowflake and Presto dialects #5289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and Presto dialects
rahulj51
commented
Jun 26, 2025
georgesittas
approved these changes
Jun 26, 2025
There was a problem hiding this comment.
This looks good, thank you @rahulj51! Just a suggestion & a question.
| @@ -2223,6 +2223,35 @@ def test_regexp_replace(self, logger): | |||
| }, | |||
| ) | |||
|
|
|||
| @mock.patch("sqlglot.generator.logger") | |||
There was a problem hiding this comment.
Why was this needed?
| @@ -166,6 +166,15 @@ def _build_regexp_replace(args: t.List) -> exp.RegexpReplace: | |||
| return regexp_replace | |||
|
|
|||
|
|
|||
| def _build_replace(args: t.List) -> exp.Replace: | |||
There was a problem hiding this comment.
Isn't the logic the same as Presto? Why do something different for Snowflake? I'd suggest extracting the Presto logic out into a helper within dialect.py and then importing it in both dialects, so that it can be reused elsewhere if needed.
|
I'll get this in and take it to the finish line, thanks! |
Perfect. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both Snwoflake and Presto support a two argument version of REPLACE with the third argument being optional. This breaks during transpilation to other dialects and needs to be handled. This fix adds the default value for the third argument for these two dialects.
Also added unit tests for validations.