add support to changed special character handling#529
Open
are-scenic wants to merge 1 commit intotmux-plugins:masterfrom
Open
add support to changed special character handling#529are-scenic wants to merge 1 commit intotmux-plugins:masterfrom
are-scenic wants to merge 1 commit intotmux-plugins:masterfrom
Conversation
Newer versions of tmux (observed on 3.4, on Ubuntu 24.04) in comparison to the older one (observed on 3.2a, on Ubuntu 22.04) changed behavior in how special characters within the option values are returned by the command `tmux show-option -gqv`. Now, it adds a leading backslash to each special character. This breaks the expansion of environment variables that is done by the function `resurrect_dir()` (in #/scripts/helpers.sh). This commit adds support for this new representation of special characters, in addition to the older ones. Signed-off-by: Arseniy Aharonov <aaharonov@nvidia.com>
Author
|
@bruno-, could you please review the suggested modification? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer versions of tmux (observed on 3.4, on Ubuntu 24.04) in comparison to the older one (observed on 3.2a, on Ubuntu 22.04) changed behavior in how special characters within the option values are returned by the command
tmux show-option -gqv. Now, it adds a leading backslash to each special character.On Ubuntu 22.04 with tmux 3.2a:
On Ubuntu 24.04 with tmux 3.4:
This breaks the expansion of environment variables that is done by the function
resurrect_dir()(in #/scripts/helpers.sh).This commit adds support for this new representation of special characters, in addition to the older ones.