Use 'cat' binary to restore pane contents rather than (potentially) using a shell command or alias #313
Conversation
`pane_creation_command` in `scripts/restore.sh` uses the string `cat` to run `/bin/cat`; however, because `pane_creation_command` is evaluated in the shell, aliases of `cat` may cause unexpected results; in my case, it runs the `bat` [1] binary, which produces weird and garbled output. By using `command -v`, we can get the path of the `cat` binary and avoid this. (Note that we don't use `which` because `which` isn't POSIX-standard.) [1]: https://github.com/sharkdp/bat
9999years
changed the title
|
Hi, I think overriding standard shell commands is an anti-pattern. I'll leave this PR open in case the community disagrees, but I'm not in favor of merging this. |
|
Even if redefining coreutils commands is an anti-pattern, running a binary using its absolute name is the correct way to send commands to a user's shell; given that this patch has no cost — it makes |
|
I have a gut feeling this will solve #192, or at least is related to it. When using Fish as a shell I always get this message in the last pane and no history: |
|
Just tested the patch and it seems it did not fix #192. |
|
Just hit this problem again today. Using Fish shell and setting an alias from |
pane_creation_commandinscripts/restore.shuses the stringcatto run/bin/cat; however, becausepane_creation_commandis evaluated in the shell, aliases ofcatmay cause unexpected results; in my case, it runs thebatbinary, which produces weird and garbled output. By usingcommand -v, we can get the path of thecatbinary and avoid this. (Note that we don't usewhichbecausewhichisn't POSIX-standard.)